All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, mfasheh@suse.com
Subject: Re: [Ocfs2-devel] [PATCH] [RFC] jbd2: Add buffer triggers
Date: Fri, 17 Oct 2008 08:28:40 -0400	[thread overview]
Message-ID: <20081017122840.GD21503@mit.edu> (raw)
In-Reply-To: <20081016194011.GA4748@mail.oracle.com>

On Thu, Oct 16, 2008 at 12:40:11PM -0700, Joel Becker wrote:
> 	Actually, I've had the fixed up patch for a week, tested even.
> You caught me this morning as I was rebasing against Linus.  Sorry I
> didn't send it out sooner.   The only difference from your version, that
> I can tell, is that I unconditionally call the commit trigger function -
> it handles checking for empty b_trigger, etc.
> 

Looks good to me.

Acked-by: "Theodore Ts'o" <tytso@mit.edu>

Given that OCFS2 is going to be the first user of this patch, I guess
it would make sense for you to push it to Linus in an ocfs2 branch?
Or would you like me to send it to Linus?

							- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Tso <tytso@mit.edu>
To: ocfs2-devel@oss.oracle.com, linux-ext4@vger.kernel.org, mfasheh@suse.com
Subject: [Ocfs2-devel] [PATCH] [RFC] jbd2: Add buffer triggers
Date: Fri, 17 Oct 2008 08:28:40 -0400	[thread overview]
Message-ID: <20081017122840.GD21503@mit.edu> (raw)
In-Reply-To: <20081016194011.GA4748@mail.oracle.com>

On Thu, Oct 16, 2008 at 12:40:11PM -0700, Joel Becker wrote:
> 	Actually, I've had the fixed up patch for a week, tested even.
> You caught me this morning as I was rebasing against Linus.  Sorry I
> didn't send it out sooner.   The only difference from your version, that
> I can tell, is that I unconditionally call the commit trigger function -
> it handles checking for empty b_trigger, etc.
> 

Looks good to me.

Acked-by: "Theodore Ts'o" <tytso@mit.edu>

Given that OCFS2 is going to be the first user of this patch, I guess
it would make sense for you to push it to Linus in an ocfs2 branch?
Or would you like me to send it to Linus?

							- Ted

  parent reply	other threads:[~2008-10-17 12:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-17 23:26 [PATCH] [RFC] jbd2: Add buffer triggers Joel Becker
2008-09-17 23:26 ` [Ocfs2-devel] " Joel Becker
2008-09-17 23:27 ` [PATCH] ocfs2: Use the new jbd_journal_set_triggers() to printk Joel Becker
2008-09-17 23:27   ` [Ocfs2-devel] " Joel Becker
2008-09-19 21:46 ` [PATCH] [RFC] jbd2: Add buffer triggers Andreas Dilger
2008-09-19 21:46   ` [Ocfs2-devel] " Andreas Dilger
2008-09-20  3:36   ` Joel Becker
2008-09-20  3:36     ` Joel Becker
2008-09-29  1:25 ` Theodore Tso
2008-09-29  1:25   ` [Ocfs2-devel] " Theodore Tso
2008-10-04  0:03   ` Theodore Tso
2008-10-04  0:03     ` [Ocfs2-devel] " Theodore Tso
2008-10-06 21:37     ` Joel Becker
2008-10-06 21:37       ` [Ocfs2-devel] " Joel Becker
2008-10-06 21:42       ` Joel Becker
2008-10-06 21:42         ` [Ocfs2-devel] " Joel Becker
2008-10-06 23:32         ` Theodore Tso
2008-10-06 23:32           ` [Ocfs2-devel] " Theodore Tso
2008-10-07  1:01           ` Joel Becker
2008-10-07  1:01             ` Joel Becker
2008-10-08 23:17             ` Joel Becker
2008-10-08 23:17               ` Joel Becker
2008-10-16 17:42               ` Theodore Tso
2008-10-16 17:42                 ` Theodore Tso
2008-10-16 19:40                 ` Joel Becker
2008-10-16 19:40                   ` Joel Becker
2008-10-16 19:44                   ` Joel Becker
2008-10-16 19:44                     ` [Ocfs2-devel] " Joel Becker
2008-10-17 12:28                   ` Theodore Tso [this message]
2008-10-17 12:28                     ` Theodore Tso
2008-10-17 17:11                     ` Mark Fasheh
2008-10-17 17:11                       ` Mark Fasheh
2008-10-07  1:04           ` Joel Becker
2008-10-07  1:04             ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081017122840.GD21503@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.