From: Willy Tarreau <w@1wt.eu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Hugh Dickins <hugh@veritas.com>, Peter Cordes <peter@cordes.ca>,
Bodo Eggert <7eggert@gmx.de>,
David Newall <davidn@davidnewall.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: no way to swapoff a deleted swap file?
Date: Sat, 18 Oct 2008 22:56:47 +0200 [thread overview]
Message-ID: <20081018205647.GA29946@1wt.eu> (raw)
In-Reply-To: <20081018204948.GA22140@infradead.org>
On Sat, Oct 18, 2008 at 04:49:48PM -0400, Christoph Hellwig wrote:
> On Sat, Oct 18, 2008 at 09:45:14PM +0100, Hugh Dickins wrote:
> > --- 2.6.27/fs/namei.c 2008-10-09 23:13:53.000000000 +0100
> > +++ linux/fs/namei.c 2008-10-18 21:33:01.000000000 +0100
> > @@ -1407,7 +1407,7 @@ static int may_delete(struct inode *dir,
> > if (IS_APPEND(dir))
> > return -EPERM;
> > if (check_sticky(dir, victim->d_inode)||IS_APPEND(victim->d_inode)||
> > - IS_IMMUTABLE(victim->d_inode))
> > + IS_IMMUTABLE(victim->d_inode) || IS_SWAPFILE(victim->d_inode))
> > return -EPERM;
> > if (isdir) {
> > if (!S_ISDIR(victim->d_inode->i_mode))
>
> Looks reasonable.
I like the idea and the simplicity a lot !
Willy
WARNING: multiple messages have this Message-ID (diff)
From: Willy Tarreau <w@1wt.eu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Hugh Dickins <hugh@veritas.com>, Peter Cordes <peter@cordes.ca>,
Bodo Eggert <7eggert@gmx.de>,
David Newall <davidn@davidnewall.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: no way to swapoff a deleted swap file?
Date: Sat, 18 Oct 2008 22:56:47 +0200 [thread overview]
Message-ID: <20081018205647.GA29946@1wt.eu> (raw)
In-Reply-To: <20081018204948.GA22140@infradead.org>
On Sat, Oct 18, 2008 at 04:49:48PM -0400, Christoph Hellwig wrote:
> On Sat, Oct 18, 2008 at 09:45:14PM +0100, Hugh Dickins wrote:
> > --- 2.6.27/fs/namei.c 2008-10-09 23:13:53.000000000 +0100
> > +++ linux/fs/namei.c 2008-10-18 21:33:01.000000000 +0100
> > @@ -1407,7 +1407,7 @@ static int may_delete(struct inode *dir,
> > if (IS_APPEND(dir))
> > return -EPERM;
> > if (check_sticky(dir, victim->d_inode)||IS_APPEND(victim->d_inode)||
> > - IS_IMMUTABLE(victim->d_inode))
> > + IS_IMMUTABLE(victim->d_inode) || IS_SWAPFILE(victim->d_inode))
> > return -EPERM;
> > if (isdir) {
> > if (!S_ISDIR(victim->d_inode->i_mode))
>
> Looks reasonable.
I like the idea and the simplicity a lot !
Willy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-18 20:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bnlDw-5vQ-7@gated-at.bofh.it>
[not found] ` <bnwpg-2EA-17@gated-at.bofh.it>
[not found] ` <bnJFK-3bu-7@gated-at.bofh.it>
2008-10-16 23:43 ` no way to swapoff a deleted swap file? Bodo Eggert
2008-10-16 23:43 ` Bodo Eggert
2008-10-16 23:43 ` Bodo Eggert
[not found] ` <bnR0A-4kq-1@gated-at.bofh.it>
2008-10-17 8:20 ` Bodo Eggert
2008-10-17 8:20 ` Bodo Eggert
2008-10-17 12:17 ` Hugh Dickins
2008-10-17 12:17 ` Hugh Dickins
2008-10-17 12:36 ` David Newall
2008-10-17 12:36 ` David Newall
2008-10-17 22:42 ` Bodo Eggert
2008-10-17 22:42 ` Bodo Eggert
2008-10-18 0:31 ` Peter Cordes
2008-10-18 0:31 ` Peter Cordes
2008-10-18 5:18 ` Willy Tarreau
2008-10-18 5:18 ` Willy Tarreau
2008-10-18 20:45 ` Hugh Dickins
2008-10-18 20:45 ` Hugh Dickins
2008-10-18 20:49 ` Christoph Hellwig
2008-10-18 20:49 ` Christoph Hellwig
2008-10-18 20:56 ` Willy Tarreau [this message]
2008-10-18 20:56 ` Willy Tarreau
2008-11-14 2:37 ` [PATCH 2.6.28?] don't unlink an active swapfile Hugh Dickins
2008-11-14 2:37 ` Hugh Dickins
2008-11-14 4:08 ` Peter Cordes
2008-11-14 4:08 ` Peter Cordes
2008-11-14 17:34 ` Christoph Hellwig
2008-11-14 17:34 ` Christoph Hellwig
2008-11-14 18:02 ` Hugh Dickins
2008-11-14 18:02 ` Hugh Dickins
2008-10-17 8:20 ` no way to swapoff a deleted swap file? Bodo Eggert
2008-10-15 20:21 Peter Cordes
2008-10-16 8:28 ` Peter Zijlstra
2008-10-16 8:28 ` Peter Zijlstra
2008-10-16 22:38 ` Hugh Dickins
2008-10-16 22:38 ` Hugh Dickins
2008-10-17 6:28 ` David Newall
2008-10-17 6:28 ` David Newall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081018205647.GA29946@1wt.eu \
--to=w@1wt.eu \
--cc=7eggert@gmx.de \
--cc=davidn@davidnewall.com \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peter@cordes.ca \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.