From: Ingo Molnar <mingo@elte.hu>
To: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
kexec-ml <kexec@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Huang Ying <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] kdump: Fix invalid access on i386 sparsemem.
Date: Mon, 20 Oct 2008 09:14:33 +0200 [thread overview]
Message-ID: <20081020071433.GC12131@elte.hu> (raw)
In-Reply-To: <48FC0E68.50902@mxs.nes.nec.co.jp>
* Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> wrote:
>
> Hi,
>
> Since linux-2.6.27, kdump has failed on i386 sparsemem kernel.
> 1st-kernel gets a panic just before switching to 2nd-kernel.
>
> The cause is that a kernel accesses invalid mem_section by
> page_to_pfn(image->swap_page) at machine_kexec().
> image->swap_page is allocated if kexec for hibernation, but
> it is not allocated if kdump. So if kdump, a kernel should
> not access the mem_section corresponding to image->swap_page.
> The attached patch fixes this invalid access.
applied to tip/x86/urgent, thanks!
Ingo
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>
Cc: kexec-ml <kexec@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Huang Ying <ying.huang@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] kdump: Fix invalid access on i386 sparsemem.
Date: Mon, 20 Oct 2008 09:14:33 +0200 [thread overview]
Message-ID: <20081020071433.GC12131@elte.hu> (raw)
In-Reply-To: <48FC0E68.50902@mxs.nes.nec.co.jp>
* Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> wrote:
>
> Hi,
>
> Since linux-2.6.27, kdump has failed on i386 sparsemem kernel.
> 1st-kernel gets a panic just before switching to 2nd-kernel.
>
> The cause is that a kernel accesses invalid mem_section by
> page_to_pfn(image->swap_page) at machine_kexec().
> image->swap_page is allocated if kexec for hibernation, but
> it is not allocated if kdump. So if kdump, a kernel should
> not access the mem_section corresponding to image->swap_page.
> The attached patch fixes this invalid access.
applied to tip/x86/urgent, thanks!
Ingo
next prev parent reply other threads:[~2008-10-20 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 4:51 [PATCH] kdump: Fix invalid access on i386 sparsemem Ken'ichi Ohmichi
2008-10-20 4:51 ` Ken'ichi Ohmichi
2008-10-20 7:14 ` Ingo Molnar [this message]
2008-10-20 7:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020071433.GC12131@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oomichi@mxs.nes.nec.co.jp \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.