[PATCH][XEN] Don't throw away cmdline parameter

[PATCH][XEN] Don't throw away cmdline parameter

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]


Hi,

attach patch avoids throwing away the first cmdline parameter.
It contains the dom0 kernel filename.

On NetBSD, this is used to set sysctl.booted_kernel
This sysctl entry is used by the kvm framework
(http://netbsd.gw.com/cgi-bin/man-cgi?kvm+3+NetBSD-current)
and savecore (http://netbsd.gw.com/cgi-bin/man-cgi?savecore+8+NetBSD-current).
The kvm framework is used by almost all system utilities.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

[-- Attachment #2: cmdline.diff --]
[-- Type: text/x-diff, Size: 345 bytes --]

$NetBSD$

--- xen/arch/x86/setup.c.orig	2008-10-08 23:39:00.000000000 +0200
+++ xen/arch/x86/setup.c
@@ -998,7 +998,6 @@ void __init __start_xen(unsigned long mb
     {
         static char dom0_cmdline[MAX_GUEST_CMDLINE];
 
-        cmdline = cmdline_cook(cmdline);
         safe_strcpy(dom0_cmdline, cmdline);
 
         if ( kextra != NULL )

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH][XEN] Don't throw away cmdline parameter

[Keir Fraser]

On 20/10/08 14:23, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> attach patch avoids throwing away the first cmdline parameter.
> It contains the dom0 kernel filename.
> 
> On NetBSD, this is used to set sysctl.booted_kernel
> This sysctl entry is used by the kvm framework
> (http://netbsd.gw.com/cgi-bin/man-cgi?kvm+3+NetBSD-current)
> and savecore (http://netbsd.gw.com/cgi-bin/man-cgi?savecore+8+NetBSD-current).
> The kvm framework is used by almost all system utilities.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Doing this would make dom0 start_info format differ from domU start_info
format. If an accurate filename is actually useful then I'd consider making
an extension to start_info format (e.g., an extra SIF_ flag and use that to
indicate an extra string appended to cmd_line[] containing the kernel
filename). Or those who do care can explicitly duplicate the filename into
the cmdline in their domain config file or bootloader config file.

 -- Keir