From: Mark Brown <broonie@sirena.org.uk>
To: Matthew Ranostay <mranostay@embeddedalley.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH2/2] hda: Add support for IDT codecs to report jack presence
Date: Tue, 21 Oct 2008 09:55:45 +0100 [thread overview]
Message-ID: <20081021085543.GD10841@sirena.org.uk> (raw)
In-Reply-To: <48FCFAC6.8090407@embeddedalley.com>
On Mon, Oct 20, 2008 at 05:40:22PM -0400, Matthew Ranostay wrote:
> Add support for reporting line out, headphone, and microphone jack insertions
> via the jack abstraction layer for the Sigmatel/IDT codec family.
The jack detection side of this looks good - I've not really reviewed
the HDA side of things. One comment:
> + if (type == SND_JACK_SWITCH)
> + type = (pin_ctl & AC_PINCTL_HP_EN)
> + ? SND_JACK_HEADPHONE : SND_JACK_LINEOUT;
So SND_JACK_SWITCH is just a jack that can be either headphone or
lineout - like I said previously, you should not define a new jack type
for this but just set both jack types when registering the jack.
next prev parent reply other threads:[~2008-10-21 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 21:40 [PATCH2/2] hda: Add support for IDT codecs to report jack presence Matthew Ranostay
2008-10-21 8:55 ` Mark Brown [this message]
2008-10-21 15:20 ` Matthew Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021085543.GD10841@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=mranostay@embeddedalley.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.