Re: [PATCH2/2] hda: Add support for IDT codecs to report jack presence

[Matthew Ranostay <mranostay@embeddedalley.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Brown wrote:
> On Mon, Oct 20, 2008 at 05:40:22PM -0400, Matthew Ranostay wrote:
>> Add support for reporting line out, headphone, and microphone jack insertions
>> via the jack abstraction layer for the Sigmatel/IDT codec family.
> 
> The jack detection side of this looks good - I've not really reviewed
> the HDA side of things.  One comment:
> 
>> +				if (type == SND_JACK_SWITCH)
>> +					type = (pin_ctl & AC_PINCTL_HP_EN)
>> +					? SND_JACK_HEADPHONE : SND_JACK_LINEOUT;
> 
> So SND_JACK_SWITCH is just a jack that can be either headphone or
> lineout - like I said previously, you should not define a new jack type
> for this but just set both jack types when registering the jack.
> 

Ok point taken :).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj980MACgkQ7s2wy7nhBHWK0QCfThegngknAyJTiaFFFFC44ID/
qiIAn1cy4PrHYl0VAhBkyjPpQ7i710lr
=F4Hs
-----END PGP SIGNATURE-----