From: Daniel Phillips <phillips@phunq.net>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms
Date: Tue, 21 Oct 2008 14:50:59 -0700 [thread overview]
Message-ID: <200810211450.59184.phillips@phunq.net> (raw)
In-Reply-To: <1224560624-9691-2-git-send-email-tytso@mit.edu>
On Monday 20 October 2008 20:43, Theodore Ts'o wrote:
> +static __u32 dx_hack_hash (const char *name, int len, int unsigned_flag)
> ...
> + if (unsigned_flag)
> + c = (int) *ucp++;
> + else
> + c = (int) *scp++;
This being a high performance hash function and all, why not something
like:
+static __u32 uchar_hack_hash (const char *name, int len)
+...
+static __u32 char_hack_hash (const char *name, int len)
+...
+static __u32 dx_hack_hash(const char *name, int len, int unsigned_flag)
+{
+ if (unsigned_flag)
+ return uchar_hack_hash(name, len);
+ return char_hack_hash(name, len);
+}
next prev parent reply other threads:[~2008-10-21 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 3:43 [PATCH,RFC] ext4: Add support for non-native signed/unsigned htree hash algorithms Theodore Ts'o
2008-10-21 3:43 ` [PATCH,RFC] ext3: " Theodore Ts'o
2008-10-21 7:16 ` Daniel Phillips
2008-10-21 21:50 ` Daniel Phillips [this message]
2008-10-21 21:53 ` Daniel Phillips
2008-10-22 16:30 ` Matt Mackall
2008-10-23 0:22 ` Andrew Morton
2008-10-23 2:56 ` Theodore Tso
2008-10-23 19:26 ` Andreas Dilger
2008-10-24 18:25 ` Jeremy Fitzhardinge
2008-10-28 14:24 ` Theodore Tso
2008-10-28 17:30 ` tony.luck
2008-11-03 7:33 ` Olaf Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810211450.59184.phillips@phunq.net \
--to=phillips@phunq.net \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.