From: Andreas Dilger <adilger@sun.com>
To: Theodore Tso <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms
Date: Thu, 23 Oct 2008 13:26:18 -0600 [thread overview]
Message-ID: <20081023192618.GS3184@webber.adilger.int> (raw)
In-Reply-To: <20081023025646.GD10369@mit.edu>
On Oct 22, 2008 22:56 -0400, Theodore Ts'o wrote:
> On Wed, Oct 22, 2008 at 05:22:21PM -0700, Andrew Morton wrote:
> > arm says
> >
> > fs/ext3/super.c: In function `ext3_fill_super':
> > fs/ext3/super.c:1750: warning: comparison is always false due to limited range of data type
> >
> > Also, is there any way in which this new code can be, umm, cleaned up?
>
> Hmm..... is it considered safe to depend on the userspace limits.h
> header file? I guess if we trust that header file to be correct we
> could check the value of CHAR_MIN and/or CHAR_MAX as defined by
> limits.h.
That would likely fail on cross-compiled environments, right?
> Alternatively we could do an #ifdef __CHAR_UNSIGNED__, which is
> defined by gcc. The manual for gcc tells us not to depend on it, but
> to depend on limits.h instead.
This warning likely is aimed at userspace for portable applications.
> Any thoughts, or comments? Does anyone know if the Intel compiler
> will DTRT with either of these approaches?
If it doesn't, then it probably has some equivalent that can be #ifdef'd
in its place.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-10-23 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 3:43 [PATCH,RFC] ext4: Add support for non-native signed/unsigned htree hash algorithms Theodore Ts'o
2008-10-21 3:43 ` [PATCH,RFC] ext3: " Theodore Ts'o
2008-10-21 7:16 ` Daniel Phillips
2008-10-21 21:50 ` Daniel Phillips
2008-10-21 21:53 ` Daniel Phillips
2008-10-22 16:30 ` Matt Mackall
2008-10-23 0:22 ` Andrew Morton
2008-10-23 2:56 ` Theodore Tso
2008-10-23 19:26 ` Andreas Dilger [this message]
2008-10-24 18:25 ` Jeremy Fitzhardinge
2008-10-28 14:24 ` Theodore Tso
2008-10-28 17:30 ` tony.luck
2008-11-03 7:33 ` Olaf Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023192618.GS3184@webber.adilger.int \
--to=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.