From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Add LTC4245 driver
Date: Tue, 21 Oct 2008 12:50:37 +0000 [thread overview]
Message-ID: <20081021145037.39f19b1c@hyperion.delvare> (raw)
In-Reply-To: <20081020160308.GA22915@ovro.caltech.edu>
Oh, BTW... Your driver doesn't build:
drivers/hwmon/ltc4245.c: In function ‘ltc4245_get_current’:
drivers/hwmon/ltc4245.c:168: warning: function declaration isn’t a prototype
drivers/hwmon/ltc4245.c:168: error: conflicting types for ‘get_current’
include/asm/current.h:24: error: previous definition of ‘get_current’ was here
Apparently get_current is a global symbol already so you will need to
come up with a different name. Prefixing your function names with the
driver name is usually a good way to protect against this.
Thanks,
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-10-21 12:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 16:03 [lm-sensors] [PATCH] hwmon: Add LTC4245 driver Ira Snyder
2008-10-20 17:29 ` Hans de Goede
2008-10-21 12:19 ` Jean Delvare
2008-10-21 12:27 ` Jean Delvare
2008-10-21 12:50 ` Jean Delvare [this message]
2008-10-21 17:44 ` Ira Snyder
2008-10-22 7:21 ` Jean Delvare
2008-10-22 23:21 ` Ira Snyder
2008-10-23 8:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021145037.39f19b1c@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.