From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Add LTC4245 driver
Date: Thu, 23 Oct 2008 08:34:13 +0000 [thread overview]
Message-ID: <20081023103413.7fe8e39a@hyperion.delvare> (raw)
In-Reply-To: <20081020160308.GA22915@ovro.caltech.edu>
On Wed, 22 Oct 2008 16:21:29 -0700, Ira Snyder wrote:
> Add Linux support for the Linear Technology LTC4245 Multiple Supply Hot
> Swap controller I2C monitoring interface.
>
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> ---
>
> Yet another revision of the ltc4245 driver. :)
>
> Changes v5 -> v6:
> * handle errors consistently
>
> Changes v4 -> v5:
> * rename the variable "current" to "curr" to workaround brokenness
> in asm/current.h on x86, powerpc64, etc.
> * check for errors when reading from i2c
> * disable probing, add example usage of force param to documentation
> * add missing #include <linux/kernel.h>
> * use i2c_smbus_read_byte_data() rather than ltc4245_read_reg()
> * const-ify some variables
>
> Changes v3 -> v4:
> * simplify ltc4245_get_voltage(), removing special casing for -12v
> * power should always be a positive value
>
> Changes v2 -> v3:
> * fix units (power?_input in uW, curr?_input in mA)
> * combine all alarm functions
> * rename power[1-4]_alarm to in[5-8]_min_alarm, per suggestions
>
> Changes v1 -> v2:
> * fixed checkpatch warnings
> * removed raw register access, per suggestions
> * changed sysfs interface, per suggestions (current, power, alarms)
>
> Documentation/hwmon/ltc4245 | 81 ++++++
> drivers/hwmon/Kconfig | 11 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/ltc4245.c | 567 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 660 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/hwmon/ltc4245
> create mode 100644 drivers/hwmon/ltc4245.c
Applied, thanks :)
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2008-10-23 8:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 16:03 [lm-sensors] [PATCH] hwmon: Add LTC4245 driver Ira Snyder
2008-10-20 17:29 ` Hans de Goede
2008-10-21 12:19 ` Jean Delvare
2008-10-21 12:27 ` Jean Delvare
2008-10-21 12:50 ` Jean Delvare
2008-10-21 17:44 ` Ira Snyder
2008-10-22 7:21 ` Jean Delvare
2008-10-22 23:21 ` Ira Snyder
2008-10-23 8:34 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023103413.7fe8e39a@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.