* [JGIT PATCH 1/3] Fix retrieval of test resources for paths containing spaces
@ 2008-10-22 8:32 Jonas Fonseca
0 siblings, 0 replies; only message in thread
From: Jonas Fonseca @ 2008-10-22 8:32 UTC (permalink / raw)
To: Robin Rosenberg, Shawn O. Pearce; +Cc: git
The use of URL.getPath() can be problematic when the repository path
contains spaces since they get encoded as %20, which will lead to a "No
such file" error when resolving to a local file. The fix first tries to
convert the resource URL to a URI (added in Java 1.5), which is then
used to construct the File instance. As a fallback use the old behavior
if a URISyntaxException is thrown.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
---
.../tst/org/spearce/jgit/util/JGitTestUtil.java | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java b/org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java
index bf2471d..eee0c14 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/util/JGitTestUtil.java
@@ -38,6 +38,7 @@
package org.spearce.jgit.util;
import java.io.File;
+import java.net.URISyntaxException;
import java.net.URL;
public abstract class JGitTestUtil {
@@ -57,7 +58,11 @@ public static File getTestResourceFile(final String fileName) {
// loaded previously
return new File("tst", fileName);
}
- return new File(url.getPath());
+ try {
+ return new File(url.toURI());
+ } catch(URISyntaxException e) {
+ return new File(url.getPath());
+ }
}
private static ClassLoader cl() {
--
1.6.0.2.1166.g8d97a.dirty
--
Jonas Fonseca
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-22 8:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-22 8:32 [JGIT PATCH 1/3] Fix retrieval of test resources for paths containing spaces Jonas Fonseca
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.