All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: Petr Tesarik <ptesarik@suse.cz>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	tee@sgi.com
Subject: Re: [PATCH 0/2] enable irqs when waiting for rwlocks
Date: Thu, 23 Oct 2008 14:12:32 +0000	[thread overview]
Message-ID: <20081023141232.GC8483@sgi.com> (raw)
In-Reply-To: <48FF6389.9050408@hp.com>

On Wed, Oct 22, 2008 at 10:31:53AM -0700, Rick Jones wrote:
> Petr Tesarik wrote:
>> Hello,
>>
>> SGI has observed that on large systems, interrupts are not serviced for
>> a long period of time when waiting for a rwlock. The following patch
>> series re-enables irqs while waiting for the lock, resembling the code
>> which is already there for spinlocks.
>
> Perhaps I'm just out in left field, but that (and the similar behaviour  
> for obtaining a spinlock?) feels like treating a symptom rather than a  
> root cause where the root cause would appear to be long lock hold  
> times/contention?

Sometimes lock contention on large systems will take a few seconds to
pass.  This is normal behavior which simply can not be eliminated.  For
those cases, we need to rely upon being able to re-enable interrupts and
allowing other operations to continue normally.  Simply put, in some
cases, nothing more can be done.

Thanks,
Robin

WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: Petr Tesarik <ptesarik@suse.cz>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	tee@sgi.com
Subject: Re: [PATCH 0/2] enable irqs when waiting for rwlocks
Date: Thu, 23 Oct 2008 09:12:32 -0500	[thread overview]
Message-ID: <20081023141232.GC8483@sgi.com> (raw)
In-Reply-To: <48FF6389.9050408@hp.com>

On Wed, Oct 22, 2008 at 10:31:53AM -0700, Rick Jones wrote:
> Petr Tesarik wrote:
>> Hello,
>>
>> SGI has observed that on large systems, interrupts are not serviced for
>> a long period of time when waiting for a rwlock. The following patch
>> series re-enables irqs while waiting for the lock, resembling the code
>> which is already there for spinlocks.
>
> Perhaps I'm just out in left field, but that (and the similar behaviour  
> for obtaining a spinlock?) feels like treating a symptom rather than a  
> root cause where the root cause would appear to be long lock hold  
> times/contention?

Sometimes lock contention on large systems will take a few seconds to
pass.  This is normal behavior which simply can not be eliminated.  For
those cases, we need to rely upon being able to re-enable interrupts and
allowing other operations to continue normally.  Simply put, in some
cases, nothing more can be done.

Thanks,
Robin

  reply	other threads:[~2008-10-23 14:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22  8:33 [PATCH 0/2] enable irqs when waiting for rwlocks Petr Tesarik
2008-10-22  8:33 ` Petr Tesarik
2008-10-22  8:34 ` [PATCH 1/2] Allow rwlocks to re-enable interrupts Petr Tesarik
2008-10-22  8:34   ` Petr Tesarik
2008-10-22  8:45   ` Peter Zijlstra
2008-10-22  8:45     ` Peter Zijlstra
2008-10-22  8:58     ` Petr Tesarik
2008-10-22  8:58       ` Petr Tesarik
2008-10-22 17:24       ` Peter Zijlstra
2008-10-22 17:24         ` Peter Zijlstra
2008-10-22 19:05         ` Matthew Wilcox
2008-10-22 19:05           ` Matthew Wilcox
2008-10-22 19:19           ` Peter Zijlstra
2008-10-22 19:19             ` Peter Zijlstra
2008-10-22 17:31 ` [PATCH 0/2] enable irqs when waiting for rwlocks Rick Jones
2008-10-22 17:31   ` Rick Jones
2008-10-23 14:12   ` Robin Holt [this message]
2008-10-23 14:12     ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081023141232.GC8483@sgi.com \
    --to=holt@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptesarik@suse.cz \
    --cc=rick.jones2@hp.com \
    --cc=tee@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.