From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-next@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
ppc-dev <linuxppc-dev@ozlabs.org>, Mike Travis <travis@sgi.com>
Subject: linux-next: rr tree build failure
Date: Thu, 23 Oct 2008 15:52:28 +1100 [thread overview]
Message-ID: <20081023155228.c8fa9da8.sfr@canb.auug.org.au> (raw)
Hi Rusty,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
arch/powerpc/platforms/cell/spu_base.c: In function 'mm_needs_global_tlbie':
arch/powerpc/platforms/cell/spu_base.c:117: error: implicit declaration of function '__cpus_setall'
Caused by commit 20ec1a8465bd6d2e7e68fa5a7b09309c920b4792
("cpumask:add-struct-cpumask") which removed __cpus_setall from
include/linux/cpumask.h.
I applied the hack patch below (which is probably not what we want).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Oct 2008 15:36:21 +1100
Subject: [PATCH] powerpc/spu: cpumask updates fallout.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/platforms/cell/spu_base.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index a5bdb89..a876904 100644
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -111,10 +111,13 @@ void spu_flush_all_slbs(struct mm_struct *mm)
*/
static inline void mm_needs_global_tlbie(struct mm_struct *mm)
{
- int nr = (NR_CPUS > 1) ? NR_CPUS : NR_CPUS + 1;
-
/* Global TLBIE broadcast required with SPEs. */
- __cpus_setall(&mm->cpu_vm_mask, nr);
+ if (NR_CPUS > 1)
+ cpumask_setall(&mm->cpu_vm_mask);
+ else {
+ cpumask_set_cpu(0, &mm->cpu_vm_mask);
+ cpumask_set_cpu(1, &mm->cpu_vm_mask);
+ }
}
void spu_associate_mm(struct spu *spu, struct mm_struct *mm)
--
1.5.6.5
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-next@vger.kernel.org, Mike Travis <travis@sgi.com>,
ppc-dev <linuxppc-dev@ozlabs.org>
Subject: linux-next: rr tree build failure
Date: Thu, 23 Oct 2008 15:52:28 +1100 [thread overview]
Message-ID: <20081023155228.c8fa9da8.sfr@canb.auug.org.au> (raw)
Hi Rusty,
Today's linux-next build (powerpc ppc64_defconfig) failed like this:
arch/powerpc/platforms/cell/spu_base.c: In function 'mm_needs_global_tlbie':
arch/powerpc/platforms/cell/spu_base.c:117: error: implicit declaration of function '__cpus_setall'
Caused by commit 20ec1a8465bd6d2e7e68fa5a7b09309c920b4792
("cpumask:add-struct-cpumask") which removed __cpus_setall from
include/linux/cpumask.h.
I applied the hack patch below (which is probably not what we want).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Oct 2008 15:36:21 +1100
Subject: [PATCH] powerpc/spu: cpumask updates fallout.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/platforms/cell/spu_base.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index a5bdb89..a876904 100644
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -111,10 +111,13 @@ void spu_flush_all_slbs(struct mm_struct *mm)
*/
static inline void mm_needs_global_tlbie(struct mm_struct *mm)
{
- int nr = (NR_CPUS > 1) ? NR_CPUS : NR_CPUS + 1;
-
/* Global TLBIE broadcast required with SPEs. */
- __cpus_setall(&mm->cpu_vm_mask, nr);
+ if (NR_CPUS > 1)
+ cpumask_setall(&mm->cpu_vm_mask);
+ else {
+ cpumask_set_cpu(0, &mm->cpu_vm_mask);
+ cpumask_set_cpu(1, &mm->cpu_vm_mask);
+ }
}
void spu_associate_mm(struct spu *spu, struct mm_struct *mm)
--
1.5.6.5
next reply other threads:[~2008-10-23 5:02 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 4:52 Stephen Rothwell [this message]
2008-10-23 4:52 ` linux-next: rr tree build failure Stephen Rothwell
2008-10-23 13:31 ` Rusty Russell
2008-10-23 13:31 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2009-12-11 1:26 Stephen Rothwell
2009-12-14 4:35 ` Stephen Rothwell
2009-12-15 3:52 ` Rusty Russell
2009-12-15 4:36 ` Stephen Rothwell
2009-12-17 22:05 ` Stephen Rothwell
2009-11-12 8:03 Stephen Rothwell
2009-11-12 8:03 ` Stephen Rothwell
2009-11-12 9:02 ` Benjamin Herrenschmidt
2009-11-12 9:02 ` Benjamin Herrenschmidt
2009-11-12 10:50 ` Stephen Rothwell
2009-11-12 10:50 ` Stephen Rothwell
2009-11-12 7:48 Stephen Rothwell
2009-11-11 3:01 Stephen Rothwell
2009-11-11 8:33 ` Rusty Russell
2009-09-09 3:47 Stephen Rothwell
2009-09-09 14:32 ` Siarhei Liakh
2009-09-11 3:00 ` Siarhei Liakh
2009-09-15 3:27 ` Stephen Rothwell
2009-09-22 5:15 ` Rusty Russell
2009-08-03 3:32 Stephen Rothwell
2009-08-03 17:55 ` Bjorn Helgaas
2009-08-03 20:22 ` Bjorn Helgaas
2009-08-03 23:18 ` Rusty Russell
2009-08-10 3:55 ` Stephen Rothwell
2009-08-10 3:56 ` Stephen Rothwell
2009-06-23 6:14 Stephen Rothwell
2009-06-24 3:24 ` Rusty Russell
2009-06-24 6:31 ` Stephen Rothwell
2009-06-15 6:40 Stephen Rothwell
2009-06-15 7:26 ` Stephen Rothwell
2009-06-15 8:52 ` David Miller
2009-06-15 10:39 ` Rusty Russell
2009-06-11 9:07 Stephen Rothwell
2009-06-11 13:08 ` Rusty Russell
2009-06-09 10:12 Stephen Rothwell
2009-06-10 7:26 ` Rusty Russell
2009-06-10 8:11 ` Stephen Rothwell
2009-03-17 2:45 Stephen Rothwell
2009-03-05 8:33 Stephen Rothwell
2009-03-06 5:23 ` Rusty Russell
2009-01-07 3:04 Stephen Rothwell
2009-01-06 3:41 Stephen Rothwell
2008-12-29 8:12 Stephen Rothwell
2008-12-29 15:23 ` Mike Travis
2008-12-29 21:01 ` Rusty Russell
2008-11-25 6:45 Stephen Rothwell
2008-11-25 11:47 ` Rusty Russell
2008-11-25 12:36 ` Christian Borntraeger
2008-11-27 8:11 ` Rusty Russell
2008-11-24 3:31 Stephen Rothwell
2008-11-24 17:07 ` Rusty Russell
2008-11-21 3:19 Stephen Rothwell
2008-11-21 10:58 ` Rusty Russell
2008-11-21 18:34 ` Greg KH
2008-11-22 2:31 ` Rusty Russell
2008-11-22 6:41 ` Greg KH
2008-11-22 17:29 ` Pete Zaitcev
2008-11-24 4:11 ` Rusty Russell
2008-11-24 4:08 ` Rusty Russell
2008-11-24 4:22 ` Pete Zaitcev
2008-11-20 3:50 Stephen Rothwell
2008-10-23 4:51 Stephen Rothwell
2008-10-23 13:02 ` Rusty Russell
2008-06-26 6:50 Stephen Rothwell
2008-06-26 7:49 ` Christian Borntraeger
2008-06-27 3:15 ` Rusty Russell
2008-06-25 6:58 Stephen Rothwell
2008-06-25 7:35 ` Christian Borntraeger
2008-06-25 8:30 ` Rusty Russell
2008-06-25 9:08 ` Christian Borntraeger
2008-06-25 6:44 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023155228.c8fa9da8.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=benh@kernel.crashing.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.