All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Mirkin <major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
To: devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Devel] Re: [PATCH 05/10] Introduce function to dump process
Date: Fri, 24 Oct 2008 08:40:16 +0400	[thread overview]
Message-ID: <200810240840.17531.major@openvz.org> (raw)
In-Reply-To: <20081020174801.GB29092-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

On Monday 20 October 2008 21:48 Serge E. Hallyn wrote:
> Quoting Andrey Mirkin (major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org):
> > +	t->cpt_uid = tsk->uid;
> > +	t->cpt_euid = tsk->euid;
> > +	t->cpt_suid = tsk->suid;
> > +	t->cpt_fsuid = tsk->fsuid;
> > +	t->cpt_gid = tsk->gid;
> > +	t->cpt_egid = tsk->egid;
> > +	t->cpt_sgid = tsk->sgid;
> > +	t->cpt_fsgid = tsk->fsgid;
>
> I don't see where any of these are restored.  (Obviously, I wanted
> to think about how you're verifying the restarter's authorization
> to do so)

Well, right now I don't use them during restore to simplify restart procedure 
and make it more clear for reviewers. In OpenVZ we are doing all restart 
procedure with root's privileges and relying on fact that all such IDs will 
be the same during restart (as we are restarting a container and its file 
system will be the same during restart).

Andrey

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Mirkin <major@openvz.org>
To: devel@openvz.org
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Devel] Re: [PATCH 05/10] Introduce function to dump process
Date: Fri, 24 Oct 2008 08:40:16 +0400	[thread overview]
Message-ID: <200810240840.17531.major@openvz.org> (raw)
In-Reply-To: <20081020174801.GB29092@us.ibm.com>

On Monday 20 October 2008 21:48 Serge E. Hallyn wrote:
> Quoting Andrey Mirkin (major@openvz.org):
> > +	t->cpt_uid = tsk->uid;
> > +	t->cpt_euid = tsk->euid;
> > +	t->cpt_suid = tsk->suid;
> > +	t->cpt_fsuid = tsk->fsuid;
> > +	t->cpt_gid = tsk->gid;
> > +	t->cpt_egid = tsk->egid;
> > +	t->cpt_sgid = tsk->sgid;
> > +	t->cpt_fsgid = tsk->fsgid;
>
> I don't see where any of these are restored.  (Obviously, I wanted
> to think about how you're verifying the restarter's authorization
> to do so)

Well, right now I don't use them during restore to simplify restart procedure 
and make it more clear for reviewers. In OpenVZ we are doing all restart 
procedure with root's privileges and relying on fact that all such IDs will 
be the same during restart (as we are restarting a container and its file 
system will be the same during restart).

Andrey

  parent reply	other threads:[~2008-10-24  4:40 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 23:11 [PATCH 0/10] OpenVZ kernel based checkpointing/restart (v2) Andrey Mirkin
2008-10-17 23:11 ` Andrey Mirkin
2008-10-17 23:11 ` [PATCH 01/10] Introduce trivial sys_checkpoint and sys_restore system calls Andrey Mirkin
     [not found]   ` <1224285098-573-2-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11     ` [PATCH 02/10] Make checkpoint/restart functionality modular Andrey Mirkin
2008-10-17 23:11       ` Andrey Mirkin
2008-10-20 16:51       ` Dave Hansen
     [not found]       ` <1224285098-573-3-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11         ` [PATCH 03/10] Introduce context structure needed during checkpointing/restart Andrey Mirkin
2008-10-17 23:11           ` Andrey Mirkin
     [not found]           ` <1224285098-573-4-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11             ` [PATCH 04/10] Introduce container dump function Andrey Mirkin
2008-10-17 23:11               ` Andrey Mirkin
     [not found]               ` <1224285098-573-5-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11                 ` [PATCH 05/10] Introduce function to dump process Andrey Mirkin
2008-10-17 23:11                   ` Andrey Mirkin
2008-10-20 11:02                   ` Louis Rilling
2008-10-24  4:15                     ` [Devel] " Andrey Mirkin
     [not found]                     ` <20081020110226.GP15171-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2008-10-24  4:15                       ` Andrey Mirkin
     [not found]                   ` <1224285098-573-6-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11                     ` [PATCH 06/10] Introduce functions to dump mm Andrey Mirkin
2008-10-17 23:11                       ` Andrey Mirkin
     [not found]                       ` <1224285098-573-7-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11                         ` [PATCH 07/10] Introduce function for restarting a container Andrey Mirkin
2008-10-17 23:11                           ` Andrey Mirkin
2008-10-17 23:11                           ` [PATCH 08/10] Introduce functions to restart a process Andrey Mirkin
     [not found]                             ` <1224285098-573-9-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11                               ` [PATCH 09/10] Introduce functions to restore mm Andrey Mirkin
2008-10-20  9:23                               ` [PATCH 08/10] Introduce functions to restart a process Cedric Le Goater
2008-10-20  9:23                                 ` Cedric Le Goater
2008-10-22  8:49                                 ` [Devel] " Andrey Mirkin
2008-10-22  9:25                                   ` Louis Rilling
     [not found]                                     ` <20081022092502.GW15171-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2008-10-22 10:06                                       ` Greg Kurz
2008-10-22 10:12                                       ` Andrey Mirkin
2008-10-22 10:12                                         ` Andrey Mirkin
2008-10-22 10:46                                         ` Louis Rilling
     [not found]                                           ` <20081022104630.GY15171-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2008-10-23  8:53                                             ` Andrey Mirkin
2008-10-23  8:53                                           ` Andrey Mirkin
     [not found]                                         ` <200810221412.14174.major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-22 10:46                                           ` Louis Rilling
2008-10-22 15:25                                           ` Oren Laadan
2008-10-22 15:25                                             ` Oren Laadan
2008-10-23  9:00                                             ` Andrey Mirkin
2008-10-23 13:57                                               ` Dave Hansen
2008-10-24  3:57                                                 ` Andrey Mirkin
2008-10-25 21:10                                                   ` Oren Laadan
2008-10-29 14:52                                                     ` Andrey Mirkin
2008-10-30 15:59                                                       ` Oren Laadan
     [not found]                                                       ` <200810291752.19281.major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-30 15:59                                                         ` Oren Laadan
     [not found]                                                     ` <49038B4C.2010009-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-29 14:52                                                       ` Andrey Mirkin
     [not found]                                                   ` <200810240757.38012.major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-25 21:10                                                     ` Oren Laadan
2008-10-24  3:57                                                 ` Andrey Mirkin
     [not found]                                               ` <200810231300.50628.amirkin-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2008-10-23 13:57                                                 ` Dave Hansen
     [not found]                                             ` <48FF45CF.5000306-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-23  9:00                                               ` Andrey Mirkin
2008-10-22 10:06                                     ` Greg Kurz
     [not found]                                       ` <1224669979.4210.15.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-10-22 10:44                                         ` Louis Rilling
2008-10-22 10:44                                       ` Louis Rilling
2008-10-22 12:44                                         ` Greg Kurz
     [not found]                                         ` <20081022104448.GX15171-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2008-10-22 12:44                                           ` Greg Kurz
     [not found]                                   ` <200810221249.55600.major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-22  9:25                                     ` Louis Rilling
2008-10-22 12:47                                     ` Cedric Le Goater
2008-10-22 12:47                                   ` Cedric Le Goater
     [not found]                                     ` <48FF20F6.1040505-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-23  9:54                                       ` Andrey Mirkin
2008-10-23  9:54                                     ` Andrey Mirkin
2008-10-23 13:49                                       ` Dave Hansen
2008-10-24  4:04                                         ` Andrey Mirkin
2008-10-24  4:04                                         ` Andrey Mirkin
     [not found]                                       ` <200810231354.47033.major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-23 13:49                                         ` Dave Hansen
     [not found]                                 ` <48FC4E0C.7050008-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2008-10-22  8:49                                   ` Andrey Mirkin
2008-10-20 13:25                               ` Louis Rilling
2008-10-20 13:25                                 ` Louis Rilling
     [not found]                                 ` <20081020132536.GS15171-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2008-10-23 10:56                                   ` [Devel] " Andrey Mirkin
2008-10-23 10:56                                 ` Andrey Mirkin
2008-10-17 23:11                             ` [PATCH 09/10] Introduce functions to restore mm Andrey Mirkin
     [not found]                               ` <1224285098-573-10-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11                                 ` [PATCH 10/10] Add support for multiple processes Andrey Mirkin
2008-10-17 23:11                               ` Andrey Mirkin
     [not found]                                 ` <1224285098-573-11-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-27 15:58                                   ` Oren Laadan
2008-10-27 15:58                                 ` Oren Laadan
2008-10-30  4:55                                   ` [Devel] " Andrey Mirkin
     [not found]                                   ` <4905E50C.8020803-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-10-30  4:55                                     ` Andrey Mirkin
     [not found]                           ` <1224285098-573-8-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11                             ` [PATCH 08/10] Introduce functions to restart a process Andrey Mirkin
2008-10-20 12:25                         ` [PATCH 06/10] Introduce functions to dump mm Louis Rilling
2008-10-20 12:25                           ` Louis Rilling
     [not found]                           ` <20081020122514.GR15171-Hu8+6S1rdjywhHL9vcZdMVaTQe2KTcn/@public.gmane.org>
2008-10-22  8:58                             ` [Devel] " Andrey Mirkin
2008-10-22  8:58                           ` Andrey Mirkin
2008-10-20 17:21                         ` Dave Hansen
2008-10-20 17:21                       ` Dave Hansen
2008-10-23  8:43                         ` [Devel] " Andrey Mirkin
2008-10-23  8:43                         ` Andrey Mirkin
2008-10-23 13:51                           ` Dave Hansen
2008-10-24  4:07                             ` Andrey Mirkin
2008-10-24  4:07                             ` Andrey Mirkin
     [not found]                           ` <200810231243.42181.major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-23 13:51                             ` Dave Hansen
2008-10-20 11:02                     ` [PATCH 05/10] Introduce function to dump process Louis Rilling
2008-10-20 17:48                     ` Serge E. Hallyn
2008-10-20 17:48                   ` Serge E. Hallyn
     [not found]                     ` <20081020174801.GB29092-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-10-24  4:40                       ` Andrey Mirkin [this message]
2008-10-24  4:40                         ` [Devel] " Andrey Mirkin
2008-10-20 17:02             ` [PATCH 03/10] Introduce context structure needed during checkpointing/restart Dave Hansen
2008-10-20 17:02               ` Dave Hansen
2008-10-29 15:30               ` [Devel] " Andrey Mirkin
2008-10-29 15:30               ` Andrey Mirkin
2008-10-20 16:51         ` [PATCH 02/10] Make checkpoint/restart functionality modular Dave Hansen
2008-10-20 16:59         ` Serge E. Hallyn
2008-10-20 16:59       ` Serge E. Hallyn
     [not found] ` <1224285098-573-1-git-send-email-major-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-10-17 23:11   ` [PATCH 01/10] Introduce trivial sys_checkpoint and sys_restore system calls Andrey Mirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810240840.17531.major@openvz.org \
    --to=major-gefaqzzx7r8dnm+yrofe0a@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.