From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MIPS] IP22: Small cleanups
Date: Sat, 25 Oct 2008 15:27:44 +0100 [thread overview]
Message-ID: <20081025142740.GB1827@linux-mips.org> (raw)
In-Reply-To: <1224888417-26494-1-git-send-email-dmitri.vorobiev@movial.fi>
On Sat, Oct 25, 2008 at 01:46:56AM +0300, Dmitri Vorobiev wrote:
> diff --git a/arch/mips/sgi-ip22/ip22-int.c b/arch/mips/sgi-ip22/ip22-int.c
> index f6d9bf4..5b9b4f3 100644
> --- a/arch/mips/sgi-ip22/ip22-int.c
> +++ b/arch/mips/sgi-ip22/ip22-int.c
> @@ -16,6 +16,7 @@
> #include <linux/sched.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> +#include <linux/time.h>
>
> #include <asm/mipsregs.h>
> #include <asm/addrspace.h>
> @@ -23,7 +24,6 @@
> #include <asm/sgi/ioc.h>
> #include <asm/sgi/hpc3.h>
> #include <asm/sgi/ip22.h>
> -#include <asm/time.h>
<linux/time.h> does not include <asm/time.h>. This sort of stuff happens
if you believe checkpatch.pl. You only got away because the header isn't
needed anyway. I'll apply the patch with this bit dropped.
Ralf
PS: Suspicion breeds confidence. At least in case of checkpatch ;-)
prev parent reply other threads:[~2008-10-25 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 22:46 [PATCH] [MIPS] IP22: Small cleanups Dmitri Vorobiev
2008-10-24 22:46 ` [PATCH] [MIPS] sgi_btns: add license specification Dmitri Vorobiev
2008-10-25 14:45 ` Ralf Baechle
2008-10-25 14:27 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081025142740.GB1827@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.