From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MIPS] sgi_btns: add license specification
Date: Sat, 25 Oct 2008 15:45:02 +0100 [thread overview]
Message-ID: <20081025144502.GA2050@linux-mips.org> (raw)
In-Reply-To: <1224888417-26494-2-git-send-email-dmitri.vorobiev@movial.fi>
On Sat, Oct 25, 2008 at 01:46:57AM +0300, Dmitri Vorobiev wrote:
> The SGI Volume Button interface driver uses GPL-only symbols
> platform_driver_unregister and platform_driver_register, but
> lacks license specification. Thus, when compiled as a module,
> this driver cannot be installed. This patch fixes this by
> adding the MODULE_LICENSE() specification.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Patch is correct - but it stumped my nose at another bug.
A platform driver is supposed to be safe if loaded into a kernel for another
machine. With the #ifdef'ed sections of this driver, a crash would be
likely if the module built for IP22 would be loaded into an IP32 kernel or
vice versa.
Ralf
next prev parent reply other threads:[~2008-10-25 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 22:46 [PATCH] [MIPS] IP22: Small cleanups Dmitri Vorobiev
2008-10-24 22:46 ` [PATCH] [MIPS] sgi_btns: add license specification Dmitri Vorobiev
2008-10-25 14:45 ` Ralf Baechle [this message]
2008-10-25 14:27 ` [PATCH] [MIPS] IP22: Small cleanups Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081025144502.GA2050@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.