* [ath9k-devel] [PATCH] ath9k: remove useless conditional
@ 2008-10-26 15:24 ` Bob Copeland
0 siblings, 0 replies; 2+ messages in thread
From: Bob Copeland @ 2008-10-26 15:24 UTC (permalink / raw)
To: ath9k-devel
Hi,
I saw this while reading through the ath9k code. Not sure if it was
just dead code or if it should be returning false.
From: Bob Copeland <me@bobcopeland.com>
Subject: [PATCH] ath9k: remove useless conditional
ath9k_hw_keyreset returns true in either branch.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath9k/hw.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c
index 98bc25c..c920822 100644
--- a/drivers/net/wireless/ath9k/hw.c
+++ b/drivers/net/wireless/ath9k/hw.c
@@ -7194,9 +7194,6 @@ bool ath9k_hw_keyreset(struct ath_hal *ah, u16 entry)
}
- if (ah->ah_curchan == NULL)
- return true;
-
return true;
}
--
1.5.4.2.182.gb3092
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ath9k: remove useless conditional
@ 2008-10-26 15:24 ` Bob Copeland
0 siblings, 0 replies; 2+ messages in thread
From: Bob Copeland @ 2008-10-26 15:24 UTC (permalink / raw)
To: lrodriguez, jmalinen; +Cc: ath9k-devel, linux-wireless
Hi,
I saw this while reading through the ath9k code. Not sure if it was
just dead code or if it should be returning false.
From: Bob Copeland <me@bobcopeland.com>
Subject: [PATCH] ath9k: remove useless conditional
ath9k_hw_keyreset returns true in either branch.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/ath9k/hw.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c
index 98bc25c..c920822 100644
--- a/drivers/net/wireless/ath9k/hw.c
+++ b/drivers/net/wireless/ath9k/hw.c
@@ -7194,9 +7194,6 @@ bool ath9k_hw_keyreset(struct ath_hal *ah, u16 entry)
}
- if (ah->ah_curchan == NULL)
- return true;
-
return true;
}
--
1.5.4.2.182.gb3092
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-26 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-26 15:24 [ath9k-devel] [PATCH] ath9k: remove useless conditional Bob Copeland
2008-10-26 15:24 ` Bob Copeland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.