* [PATCH] fix comile error of hdpuftrs
@ 2008-10-18 13:37 Mariusz Kozlowski
2008-10-27 4:24 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mariusz Kozlowski @ 2008-10-18 13:37 UTC (permalink / raw)
To: lkml
Hello,
drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
--- a/drivers/misc/hdpuftrs/hdpu_nexus.c
+++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
@@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
if (!hdpu_chassis_id)
printk(KERN_WARNING "sky_nexus: "
"Unable to create proc dir entry: sky_chassis_id\n");
- }
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fix comile error of hdpuftrs
2008-10-18 13:37 [PATCH] fix comile error of hdpuftrs Mariusz Kozlowski
@ 2008-10-27 4:24 ` Andrew Morton
2008-10-27 21:46 ` Mariusz Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-10-27 4:24 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: lkml
On Sat, 18 Oct 2008 15:37:12 +0200 Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
> drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> --- a/drivers/misc/hdpuftrs/hdpu_nexus.c
> +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
> @@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
> if (!hdpu_chassis_id)
> printk(KERN_WARNING "sky_nexus: "
> "Unable to create proc dir entry: sky_chassis_id\n");
> - }
>
> return 0;
> }
This has been broken since 2.6.26.
Nobody noticed because there is no way of enabling CONFIG_HDPU_FEATURES
in Kconfig. I wonder what's up with that.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fix comile error of hdpuftrs
2008-10-27 4:24 ` Andrew Morton
@ 2008-10-27 21:46 ` Mariusz Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Mariusz Kozlowski @ 2008-10-27 21:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: lkml
Hi,
> > drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
> > drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
> >
> > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> >
> > --- a/drivers/misc/hdpuftrs/hdpu_nexus.c
> > +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
> > @@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
> > if (!hdpu_chassis_id)
> > printk(KERN_WARNING "sky_nexus: "
> > "Unable to create proc dir entry: sky_chassis_id\n");
> > - }
> >
> > return 0;
> > }
>
> This has been broken since 2.6.26.
>
> Nobody noticed because there is no way of enabling CONFIG_HDPU_FEATURES
> in Kconfig. I wonder what's up with that.
Yup. I used simple script to find the brace imbalance. Then I tried to compile it with
make drivers/misc/hdpuftrs/hdpu_nexus.o to verify this.
Mariusz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-27 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-18 13:37 [PATCH] fix comile error of hdpuftrs Mariusz Kozlowski
2008-10-27 4:24 ` Andrew Morton
2008-10-27 21:46 ` Mariusz Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.