[PATCH] disable the right device

[PATCH] disable the right device

[Phil Sutter]

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
 arch/mips/rb532/devices.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c
index 31619c6..2f22d71 100644
--- a/arch/mips/rb532/devices.c
+++ b/arch/mips/rb532/devices.c
@@ -280,7 +280,7 @@ static int __init plat_setup_devices(void)
 {
 	/* Look for the CF card reader */
 	if (!readl(IDT434_REG_BASE + DEV1MASK))
-		rb532_devs[1] = NULL;
+		rb532_devs[2] = NULL;	/* disable cf_slot0 at index 2 */
 	else {
 		cf_slot0_res[0].start =
 		    readl(IDT434_REG_BASE + DEV1BASE);
-- 
1.5.6.4

Re: [PATCH] disable the right device

[Ralf Baechle]

On Mon, Oct 27, 2008 at 02:29:57AM +0100, Phil Sutter wrote:

Thanks, applied.

  Ralf

[PATCH] irq handler must disable the handled irq

[Phil Sutter]

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
 drivers/ata/pata_rb532_cf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index f8b3ffc..a1d44a6 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -116,6 +116,8 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 		set_irq_type(info->irq, IRQ_TYPE_LEVEL_HIGH);
 	}
 
+	disable_irq(irq);
+
 	return IRQ_HANDLED;
 }
 
-- 
1.5.6.4

Re: [PATCH] irq handler must disable the handled irq

[Ralf Baechle]

On Mon, Oct 27, 2008 at 02:30:26AM +0100, Phil Sutter wrote:

>  drivers/ata/pata_rb532_cf.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Please send this patch to the IDE maintainer & list.

  Ralf

[PATCH] irq handler must disable the handled irq

[Phil Sutter]

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
 drivers/ata/pata_rb532_cf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index f8b3ffc..a1d44a6 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -116,6 +116,8 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 		set_irq_type(info->irq, IRQ_TYPE_LEVEL_HIGH);
 	}
 
+	disable_irq(irq);
+
 	return IRQ_HANDLED;
 }
 
-- 
1.5.6.4

Re: [PATCH] irq handler must disable the handled irq

[Alan Cox]

On Mon, 27 Oct 2008 15:01:47 +0100
Phil Sutter <n0-1@freewrt.org> wrote:

> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
>  drivers/ata/pata_rb532_cf.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
> index f8b3ffc..a1d44a6 100644
> --- a/drivers/ata/pata_rb532_cf.c
> +++ b/drivers/ata/pata_rb532_cf.c
> @@ -116,6 +116,8 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
>  		set_irq_type(info->irq, IRQ_TYPE_LEVEL_HIGH);
>  	}
>  
> +	disable_irq(irq);
> +

You can't call disable_irq in an IRQ handler. What are you actually
trying to do ?

Alan

Re: [PATCH] irq handler must disable the handled irq

[Phil Sutter]

On Mon, Oct 27, 2008 at 02:15:09PM +0000, Alan Cox wrote:
> You can't call disable_irq in an IRQ handler. What are you actually
> trying to do ?

Well, what I'm trying to do is getting the driver to a working state.
But it seems like I don't know what I'm actually doing. :/

The symptom I discovered was rb532_pata_irq_handler() being called over
and over again, endlessly. Calling disable_irq() from within stopped
that, so I assumed it to be right (obviously the wrong direction for a
proof).

As the working driver for 2.6.19 I have here is not based on libata, I'm
not quite sure how much code is still required and where to hook it into
the libata subsystem.

Greetings, Phil

Re: [PATCH] irq handler must disable the handled irq

[Bartlomiej Zolnierkiewicz]

On Monday 27 October 2008, Phil Sutter wrote:

> As the working driver for 2.6.19 I have here is not based on libata, I'm

Any reason why it has not been submitted?

Re: [PATCH] irq handler must disable the handled irq

[Phil Sutter]

On Mon, Oct 27, 2008 at 08:38:45PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Any reason why it has not been submitted?

Not really. Two years ago I was working at the 2.6 port of the board in
a lab semester. Shortly after having contacted the linux-mips maintainer
(who also told me to send the mentioned driver to this list) the
semester was over and everyday life at the university hit me again.

If there is demand for it, I could try to port it to git and the
already existing board support.

Greetings, Phil