From: Robert Richter <robert.richter@amd.com>
To: Carl Love <cel@us.ibm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, oprofile-list@lists.sourceforge.net,
Ingo Molnar <mingo@elte.hu>,
cel@linux.vnet.ibm.com, cbe-oss-dev@ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function
Date: Mon, 27 Oct 2008 19:26:02 +0100 [thread overview]
Message-ID: <20081027182602.GE9785@erda.amd.com> (raw)
In-Reply-To: <1224874049.20229.5.camel@carll-linux-desktop>
On 24.10.08 11:47:29, Carl Love wrote:
>
> The size of the pm_signal_local array should be equal to the
> number of SPUs being configured in the call. Currently, the
> array is of size 4 (NR_PHYS_CTRS) but being indexed by a for
> loop from 0 to 7 (NUM_SPUS_PER_NODE).
>
> Signed-off-by: Carl Love <carll@us.ibm.com>
I applied your patch to oprofile/oprofile-for-tip. Thanks Carl.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
WARNING: multiple messages have this Message-ID (diff)
From: Robert Richter <robert.richter@amd.com>
To: Carl Love <cel@us.ibm.com>
Cc: oprofile-list@lists.sourceforge.net, linuxppc-dev@ozlabs.org,
cel@linux.vnet.ibm.com, cbe-oss-dev@ozlabs.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function
Date: Mon, 27 Oct 2008 19:26:02 +0100 [thread overview]
Message-ID: <20081027182602.GE9785@erda.amd.com> (raw)
In-Reply-To: <1224874049.20229.5.camel@carll-linux-desktop>
On 24.10.08 11:47:29, Carl Love wrote:
>
> The size of the pm_signal_local array should be equal to the
> number of SPUs being configured in the call. Currently, the
> array is of size 4 (NR_PHYS_CTRS) but being indexed by a for
> loop from 0 to 7 (NUM_SPUS_PER_NODE).
>
> Signed-off-by: Carl Love <carll@us.ibm.com>
I applied your patch to oprofile/oprofile-for-tip. Thanks Carl.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2008-10-27 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 18:47 [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function Carl Love
2008-10-25 4:39 ` Michael Ellerman
2008-10-25 4:39 ` Michael Ellerman
2008-10-28 15:17 ` [UDATED PATCH] " Carl Love
2008-10-28 15:17 ` Carl Love
2008-10-29 0:51 ` Michael Ellerman
2008-10-29 0:51 ` Michael Ellerman
2008-10-29 15:06 ` [UPDATED PATCH VER2] " Carl Love
2008-10-29 15:06 ` Carl Love
2008-10-31 15:14 ` Robert Richter
2008-10-31 15:14 ` Robert Richter
2008-10-27 18:26 ` Robert Richter [this message]
2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027182602.GE9785@erda.amd.com \
--to=robert.richter@amd.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cel@linux.vnet.ibm.com \
--cc=cel@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.