[Ocfs2-devel] [PATCH 25/29] ocfs2: Implementation of local and global quota file handling

[Joel Becker <Joel.Becker@oracle.com>]

On Wed, Oct 29, 2008 at 03:29:02AM +0100, Jan Kara wrote:
> > > +/* Structure with global user / group information. We reserve some space
> > > + * for future use. */
> > > +struct ocfs2_global_disk_dqblk {
> > > +/*00*/	__le32 dqb_id;          /* ID the structure belongs to */
> > > +	__le32 dqb_use_count;   /* Number of nodes having reference to this structure */
> > > +	__le64 dqb_ihardlimit;  /* absolute limit on allocated inodes */
> > > +/*10*/	__le64 dqb_isoftlimit;  /* preferred inode limit */
> > > +	__le64 dqb_curinodes;   /* current # allocated inodes */
> > > +/*20*/	__le64 dqb_bhardlimit;  /* absolute limit on disk space */
> > > +	__le64 dqb_bsoftlimit;  /* preferred limit on disk space */
> > > +/*30*/	__le64 dqb_curspace;    /* current space occupied */
> > > +	__le64 dqb_btime;       /* time limit for excessive disk use */
> > > +/*40*/	__le64 dqb_itime;       /* time limit for excessive inode use */
> > > +	__le64 dqb_pad1;
> > > +/*50*/	__le64 dqb_pad2;
> > > +};
> > 
> > 	We also need space for the ecc data here.  It looks like ecc
> > space wasn't added to this series.  Rather than comment on each
> > structure, just let me know when that's ready.
>   What I did is, that in the end of each quotafile block there are 8 bytes
> reserved for OCFS2 use (both in local and global quota files). So these
> bytes are intended to be used for ECC. I hope that's fine.

	So every block type (disk header, dq_block, etc) has the last 8
bytes free?  This seems like something we should find a way to mention
in the disk header.

Joel

-- 

Bram's Law:
	The easier a piece of software is to write, the worse it's
	implemented in practice.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127