All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	torvalds@osdl.org, viro@zeniv.linux.org.uk,
	acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] headers: move release_kernel_lock(), reacquire_kernel_lock() to sched.c
Date: Wed, 29 Oct 2008 17:42:55 +0100	[thread overview]
Message-ID: <20081029164255.GA17213@elte.hu> (raw)
In-Reply-To: <20081029131402.GA2642@x200.localdomain>


* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Wed, Oct 29, 2008 at 06:04:37AM -0400, Christoph Hellwig wrote:
> > On Wed, Oct 29, 2008 at 07:18:27AM +0100, Ingo Molnar wrote:
> > > please dont move #ifdefs and interfaces into a .c file - if then move 
> > > it into another header file.
> > 
> > Sorry, but that makes no sense at all.  This stuff is implementation
> > private to sched.c, and adding some header for it is just braindead.
> 
> Well, yes, that was the logic behind move -- keep it private to scheduler.

i have no objections at all against the whole sched.h cleanup 
(reducing header file dependencies is a much needed activity). But 
please keep it in a header file - i.e. put it into 
kernel/sched_internals.h. (like we do it for 
kernel/lockdep_internals.h)

that could then probably be merged with kernel/sched_stats.h as well. 
(which too is an #ifdef laden interface piece of code we have moved 
into a header)

Thanks,

	Ingo

      reply	other threads:[~2008-10-29 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  4:43 [GIT] headers redux Alexey Dobriyan
2008-10-29  4:44 ` [PATCH 1/2] headers: move release_kernel_lock(), reacquire_kernel_lock() to sched.c Alexey Dobriyan
2008-10-29  4:45   ` [PATCH 2/2] headers: reduction in interrupt.h Alexey Dobriyan
2008-10-29  6:21     ` Ingo Molnar
2008-10-29  6:18   ` [PATCH 1/2] headers: move release_kernel_lock(), reacquire_kernel_lock() to sched.c Ingo Molnar
2008-10-29  6:29     ` Harvey Harrison
2008-10-29 10:04     ` Christoph Hellwig
2008-10-29 13:14       ` Alexey Dobriyan
2008-10-29 16:42         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081029164255.GA17213@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@ghostprotocols.net \
    --cc=adobriyan@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.