From: Phil Sutter <n0-1@freewrt.org>
To: linux-ide@vger.kernel.org
Subject: Re: [PATCH] fix pata-rb532-cf
Date: Sat, 1 Nov 2008 17:45:45 +0100 [thread overview]
Message-ID: <20081101164545.GB10321@nuty> (raw)
In-Reply-To: <490C833A.7010702@ru.mvista.com>
Hi,
On Sat, Nov 01, 2008 at 07:26:34PM +0300, Sergei Shtylyov wrote:
> So, I didn't get what was wrong with using readsl() and writesl()?
> Besides, using readl() and witel() this way would be wrong on BE mode
> since the data is expected to be stored to memory in the LE order.
Sorry, my fault. When having a glance at the macro definition, I messed
up the parameter's meanings and assumed the target address would be
incremented, which is normally the case when writing regular memory, not
to IO addresses.
I changed (and successfully tested) the code, patch follows.
Thanks again, Phil
next prev parent reply other threads:[~2008-11-01 16:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 21:47 [PATCH] fix pata-rb532-cf Phil Sutter
2008-10-30 22:39 ` Florian Fainelli
2008-10-30 23:20 ` Sergei Shtylyov
2008-10-31 0:09 ` Phil Sutter
2008-10-31 10:38 ` Sergei Shtylyov
2008-10-31 11:08 ` Sergei Shtylyov
2008-11-01 16:09 ` Phil Sutter
2008-11-01 16:12 ` Phil Sutter
2008-11-01 16:26 ` Sergei Shtylyov
2008-11-01 16:45 ` Sergei Shtylyov
2008-11-01 16:45 ` Phil Sutter [this message]
2008-11-01 18:09 ` Phil Sutter
2008-11-01 18:11 ` [PATCH] read and write data in 4-byte blocks Phil Sutter
2008-11-01 18:21 ` Phil Sutter
2008-11-02 21:23 ` Sergei Shtylyov
2008-11-03 13:29 ` [PATCH] pata-rb532-cf: " Phil Sutter
2008-11-03 13:45 ` Bartlomiej Zolnierkiewicz
2008-11-04 6:01 ` Jeff Garzik
2008-11-04 12:35 ` Phil Sutter
2008-11-05 11:54 ` Sergei Shtylyov
2008-11-05 12:52 ` Phil Sutter
2008-11-02 22:04 ` [PATCH] fix pata-rb532-cf Sergei Shtylyov
2008-11-02 22:45 ` Phil Sutter
2008-11-01 16:16 ` Sergei Shtylyov
2008-11-12 0:13 ` Phil Sutter
2008-11-12 0:13 ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Phil Sutter
2008-11-12 0:14 ` [PATCH] pata-rb532-cf: fix signature of the xfer function Phil Sutter
2008-11-12 2:26 ` Florian Fainelli
2008-11-12 10:54 ` Sergei Shtylyov
2008-11-12 2:25 ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Florian Fainelli
2008-11-12 10:50 ` Sergei Shtylyov
2008-11-12 20:57 ` [PATCH] fix pata-rb532-cf Bartlomiej Zolnierkiewicz
2008-11-14 23:53 ` Jeff Garzik
2009-01-11 16:13 ` Florian Fainelli
2009-01-11 20:47 ` Phil Sutter
2009-01-12 14:32 ` Florian Fainelli
2009-01-12 17:48 ` Phil Sutter
-- strict thread matches above, loose matches on Subject: below --
2008-11-17 20:04 Phil Sutter
2008-11-23 22:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081101164545.GB10321@nuty \
--to=n0-1@freewrt.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.