From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: linux-ide@vger.kernel.org
Subject: Re: [PATCH] fix pata-rb532-cf
Date: Sat, 01 Nov 2008 19:16:14 +0300 [thread overview]
Message-ID: <490C80CE.4090505@ru.mvista.com> (raw)
In-Reply-To: <20081101160930.GA10321@nuty>
Hello.
Phil Sutter wrote:
>> No. The alternatives would be to use local variable as a loop counter
>> or, better yet, using readsb()/writesb() instead of the loops...
>> Wait! The original driver used 32-bit I/O to this register, not 8-bit --
>> so it looks like you have artificially slowed it down... :-/
>>
>
> Ok, so this should be clear now. I changed the code to use readl() and
> writel() (the reads*() and writes*() versions sadly aren't useable as
> they increment the target memory pointer) which worked fine.
>
So what? This is perfectly valid. Doesn't the current code increment it?
MBR, Sergei
next prev parent reply other threads:[~2008-11-01 16:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 21:47 [PATCH] fix pata-rb532-cf Phil Sutter
2008-10-30 22:39 ` Florian Fainelli
2008-10-30 23:20 ` Sergei Shtylyov
2008-10-31 0:09 ` Phil Sutter
2008-10-31 10:38 ` Sergei Shtylyov
2008-10-31 11:08 ` Sergei Shtylyov
2008-11-01 16:09 ` Phil Sutter
2008-11-01 16:12 ` Phil Sutter
2008-11-01 16:26 ` Sergei Shtylyov
2008-11-01 16:45 ` Sergei Shtylyov
2008-11-01 16:45 ` Phil Sutter
2008-11-01 18:09 ` Phil Sutter
2008-11-01 18:11 ` [PATCH] read and write data in 4-byte blocks Phil Sutter
2008-11-01 18:21 ` Phil Sutter
2008-11-02 21:23 ` Sergei Shtylyov
2008-11-03 13:29 ` [PATCH] pata-rb532-cf: " Phil Sutter
2008-11-03 13:45 ` Bartlomiej Zolnierkiewicz
2008-11-04 6:01 ` Jeff Garzik
2008-11-04 12:35 ` Phil Sutter
2008-11-05 11:54 ` Sergei Shtylyov
2008-11-05 12:52 ` Phil Sutter
2008-11-02 22:04 ` [PATCH] fix pata-rb532-cf Sergei Shtylyov
2008-11-02 22:45 ` Phil Sutter
2008-11-01 16:16 ` Sergei Shtylyov [this message]
2008-11-12 0:13 ` Phil Sutter
2008-11-12 0:13 ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Phil Sutter
2008-11-12 0:14 ` [PATCH] pata-rb532-cf: fix signature of the xfer function Phil Sutter
2008-11-12 2:26 ` Florian Fainelli
2008-11-12 10:54 ` Sergei Shtylyov
2008-11-12 2:25 ` [PATCH] pata-rb532-cf: read/write data in 4-byte blocks Florian Fainelli
2008-11-12 10:50 ` Sergei Shtylyov
2008-11-12 20:57 ` [PATCH] fix pata-rb532-cf Bartlomiej Zolnierkiewicz
2008-11-14 23:53 ` Jeff Garzik
2009-01-11 16:13 ` Florian Fainelli
2009-01-11 20:47 ` Phil Sutter
2009-01-12 14:32 ` Florian Fainelli
2009-01-12 17:48 ` Phil Sutter
-- strict thread matches above, loose matches on Subject: below --
2008-11-17 20:04 Phil Sutter
2008-11-23 22:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490C80CE.4090505@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.