Re: [OMAP and mainline][RFC 2.6.28-rc2-omap 3/3] USB: OHCI-OMAP: Switch to gpio_request/free calls

[Jarkko Nikula <jarkko.nikula@nokia.com>]

On Fri, 31 Oct 2008 10:56:55 -0700
"ext David Brownell" <david-b@pacbell.net> wrote:

> On Friday 31 October 2008, Jarkko Nikula wrote:
> > -                       omap_request_gpio(9);
> > +                       gpio_request(9, "USB over current");
> 
> Make that "OHCI" not "USB" ... and, general comment, shorter
> labels for the GPIOs (12 bytes and less) will preserve column
> alignment in /sys/kernel/debug/gpio listings.
> 
Thanks Dave! I clearly forgot to clean this one. "OHCI ovcurr", "OHCI
err", etc?

Yes, I actually noted already before making the first set, that
probably I should sent a patch to wide the label column in debugs
listings :-)

Otherwise we have to invent artificially short labels. See e.g.

"BT host wakeup" -> "BT host wup" (looks stupid)
"ADS7846 pendown" -> "ADS7846 pdown", "ADS7846 pd" (power-down?)

IMO GPIO label will be usually longer than IRQ label since label must
include not only chip/connection info but also function of the GPIO.
E.g. "XXX enable", XXX reset", "XXX irq", "LED green", etc.


Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html