Re: [OMAP and mainline][RFC 2.6.28-rc2-omap 3/3] USB: OHCI-OMAP: Switch to gpio_request/free calls

[Jarkko Nikula <jarkko.nikula@nokia.com>]

On Tue, 11 Nov 2008 22:28:13 -0800
"ext David Brownell" <david-b@pacbell.net> wrote:

> > Do you see are there any issue to change label into last column like
> > in /proc/interrupts so that width doesn't have to be fixed?
> 
> Only that the amount of data to the right of that label
> is variable size too.  I was following a convention that
> the standard debug dump code (gpiolib) and the gpio_chip
> specific stuff all looked pretty much the same except for
> the extras (pullups, pulldowns, drive strength, debounce,
> and so on) on the right.
> 
Yep, again zero thinking from me :-)

> I'd keep it simple and just allow for fatter labels.
> Less work all around.
> 
I just sent a patch extending width to 20 bytes via LKML and you in cc
list. I looked mainline and there were many labels more than 12 but
less 20 bytes. One longer was "board a9m9750dev extirq2" but looks like
it can be squeezed.


Jarkko