From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux-pci@vger.kernel.org, kristen.c.accardi@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add option to passively listen for PCIE hotplug events
Date: Tue, 4 Nov 2008 12:45:09 +0000 [thread overview]
Message-ID: <20081104124509.GA19401@srcf.ucam.org> (raw)
In-Reply-To: <490FE1AC.5030608@jp.fujitsu.com>
On Tue, Nov 04, 2008 at 02:46:20PM +0900, Kenji Kaneshige wrote:
> I can't understand why the 'value' is set to 0 when pciehp_enable_slot()
> returns error. The 'value' here is representing whether the slot is
> occupied or not. Even if pciehp_enable_slot() returns error, it doesn't
> mean slot is not occupied. So I think it is clearly wrong thing that
> changing 'value' to 0 from 1 here.
>
> How about just ignore the return value from pciehp_enable_slot()? The
> code would be as follows.
Yeah, I agree with that.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2008-11-04 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 20:09 [PATCH] Add option to passively listen for PCIE hotplug events Matthew Garrett
2008-11-01 17:51 ` Grant Grundler
2008-11-03 13:26 ` [PATCH v2] " Matthew Garrett
2008-11-03 13:43 ` Fabio Comolli
2008-11-03 13:46 ` Matthew Garrett
2008-11-14 16:56 ` Randy Dunlap
2008-11-14 17:00 ` Matthew Garrett
2008-11-03 22:23 ` [PATCH] " Andrew Morton
2008-11-03 22:30 ` Matthew Garrett
2008-11-04 1:58 ` Kenji Kaneshige
2008-11-04 2:07 ` Matthew Garrett
2008-11-04 2:29 ` Kenji Kaneshige
2008-11-04 2:38 ` Matthew Garrett
2008-11-04 3:11 ` Kenji Kaneshige
2008-11-04 5:02 ` Matthew Garrett
2008-11-04 5:46 ` Kenji Kaneshige
2008-11-04 12:45 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104124509.GA19401@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.