All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
	linux-pci@vger.kernel.org, kristen.c.accardi@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Add option to passively listen for PCIE hotplug events
Date: Fri, 14 Nov 2008 17:00:45 +0000	[thread overview]
Message-ID: <20081114170045.GA28873@srcf.ucam.org> (raw)
In-Reply-To: <20081114085627.bcfecf31.randy.dunlap@oracle.com>

On Fri, Nov 14, 2008 at 08:56:27AM -0800, Randy Dunlap wrote:

> Is it too late to comment on these parameters?
> Please don't make users repeat the "pciehp.pciehp" name.
> This can be changed easily in the source code by keeping the variable
> names as is but using module_param_named() instead of module_param().
> One good example is drivers/video/uvesafb.c.

It maintains consistency with the existing parameter names, but after 
looking at the problem more closely I'm no longer planning to push this 
anyway.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2008-11-14 17:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 20:09 [PATCH] Add option to passively listen for PCIE hotplug events Matthew Garrett
2008-11-01 17:51 ` Grant Grundler
2008-11-03 13:26   ` [PATCH v2] " Matthew Garrett
2008-11-03 13:43     ` Fabio Comolli
2008-11-03 13:46       ` Matthew Garrett
2008-11-14 16:56     ` Randy Dunlap
2008-11-14 17:00       ` Matthew Garrett [this message]
2008-11-03 22:23 ` [PATCH] " Andrew Morton
2008-11-03 22:30   ` Matthew Garrett
2008-11-04  1:58 ` Kenji Kaneshige
2008-11-04  2:07   ` Matthew Garrett
2008-11-04  2:29     ` Kenji Kaneshige
2008-11-04  2:38       ` Matthew Garrett
2008-11-04  3:11         ` Kenji Kaneshige
2008-11-04  5:02     ` Matthew Garrett
2008-11-04  5:46       ` Kenji Kaneshige
2008-11-04 12:45         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081114170045.GA28873@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=grundler@parisc-linux.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.