* [patch] enable wchan config menu item for x86-64
@ 2008-11-06 19:10 Ken Chen
2008-11-06 21:25 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Ken Chen @ 2008-11-06 19:10 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Linux Kernel Mailing List
Ingo,
I don't know when will you phase out /proc/pid/wchan. Can we enable the
wchan config menu item for now on x86-64 arch? This will at least allow
people to enable/disable frame pointers on scheduler functions.
Signed-off-by: Ken Chen <kenchen@google.com>
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index e60c59b..38f9fb9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -367,7 +367,7 @@ config X86_RDC321X
config SCHED_NO_NO_OMIT_FRAME_POINTER
def_bool y
prompt "Single-depth WCHAN output"
- depends on X86_32
+ depends on X86
help
Calculate simpler /proc/<PID>/wchan values. If this option
is disabled then wchan values will recurse back to the
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] enable wchan config menu item for x86-64
2008-11-06 19:10 [patch] enable wchan config menu item for x86-64 Ken Chen
@ 2008-11-06 21:25 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-06 21:25 UTC (permalink / raw)
To: Ken Chen; +Cc: Linux Kernel Mailing List
* Ken Chen <kenchen@google.com> wrote:
> Ingo,
>
> I don't know when will you phase out /proc/pid/wchan. Can we enable the
> wchan config menu item for now on x86-64 arch? This will at least allow
> people to enable/disable frame pointers on scheduler functions.
>
> Signed-off-by: Ken Chen <kenchen@google.com>
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e60c59b..38f9fb9 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -367,7 +367,7 @@ config X86_RDC321X
> config SCHED_NO_NO_OMIT_FRAME_POINTER
> def_bool y
> prompt "Single-depth WCHAN output"
> - depends on X86_32
> + depends on X86
makes sense, i've added it to tip/sched/core, thanks Ken!
This will need some testing as we never did this on 64-bit, so it's
definitely a v2.6.29 item.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-06 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-06 19:10 [patch] enable wchan config menu item for x86-64 Ken Chen
2008-11-06 21:25 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.