All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Jeff Layton <jlayton@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 12/12] lockd: remove redundant rpc_shutdown_client()
Date: Thu, 6 Nov 2008 17:22:33 -0500	[thread overview]
Message-ID: <20081106222233.GH24916@fieldses.org> (raw)
In-Reply-To: <FDDB1A79-8267-4255-B4A2-3CF6C3D09C4F@oracle.com>

On Thu, Nov 06, 2008 at 05:21:05PM -0500, Chuck Lever wrote:
>
> On Nov 6, 2008, at Nov 6, 2008, 5:10 PM, J. Bruce Fields wrote:
>
>> On Thu, Nov 06, 2008 at 07:17:33AM -0500, Jeff Layton wrote:
>>> On Wed,  5 Nov 2008 15:06:51 -0500
>>> "J. Bruce Fields" <bfields@citi.umich.edu> wrote:
>>>
>>>> These clients will all be shut down by nlm_destroy_host() when we do
>>>> garbage collection a little later, so this is redundant.
>>>>
>>>> XXX: Ask Jeff Layton why he added this again?
>>>>
>>>> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
>>>> ---
>>>> fs/lockd/host.c |    8 +-------
>>>> 1 files changed, 1 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
>>>> index 73c2be2..0387c6b 100644
>>>> --- a/fs/lockd/host.c
>>>> +++ b/fs/lockd/host.c
>>>> @@ -602,14 +602,8 @@ static void expire_hosts(struct host_table  
>>>> *table)
>>>> 	struct hlist_node *pos;
>>>> 	struct nlm_host	*host;
>>>>
>>>> -	dprintk("lockd: nuking all hosts...\n");
>>>> -	for_each_host(host, pos, chain, table) {
>>>> +	for_each_host(host, pos, chain, table)
>>>> 		host->h_expires = jiffies - 1;
>>>> -		if (host->h_rpcclnt) {
>>>> -			rpc_shutdown_client(host->h_rpcclnt);
>>>> -			host->h_rpcclnt = NULL;
>>>> -		}
>>>> -	}
>>>> }
>>>>
>>>> /*
>>>
>>> Thank goodness for my OC commenting in the BZ I was using to track  
>>> this!
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=254195#c4
>>
>> We should try to get that kind of comment out of scattered bugzillas  
>> and
>> in to the code....
>
> Done.  I talked with Jeff today, who explained why this extra RPC client 
> shutdown code is here.  A documentation patch will be included in the 
> series that splits the host cache.

Cool, thanks.--b.

  reply	other threads:[~2008-11-06 22:23 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 17:28 [PATCH 00/13] kernel server-side IPv6 support Chuck Lever
     [not found] ` <20081105172351.7330.50739.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-11-05 17:28   ` [PATCH 01/13] lockd: Enable NLM use of AF_INET6 Chuck Lever
2008-11-05 17:28   ` [PATCH 02/13] NFSD: Add documenting comments for nfsctl interface Chuck Lever
2008-11-05 17:28   ` [PATCH 03/13] NFSD: Add helper functions for __write_ports() Chuck Lever
2008-11-05 17:28   ` [PATCH 04/13] NFSD: Refactor __write_ports() Chuck Lever
2008-11-05 17:28   ` [PATCH 05/13] NFSD: Prevent a buffer overflow in svc_xprt_names() Chuck Lever
2008-11-05 17:29   ` [PATCH 06/13] SUNRPC: pass buffer size to svc_addsock() and svc_sock_names() Chuck Lever
2008-11-05 17:29   ` [PATCH 07/13] SUNRPC: Switch one_sock_name() to use snprintf() Chuck Lever
2008-11-05 17:29   ` [PATCH 08/13] SUNRPC: Support AF_INET6 in one_sock_name() Chuck Lever
2008-11-05 17:29   ` [PATCH 09/13] SUNRPC: Clean up one_sock_name() Chuck Lever
2008-11-05 17:29   ` [PATCH 10/13] NFSD: Support AF_INET6 in svc_addsock() function Chuck Lever
2008-11-05 17:29   ` [PATCH 11/13] NFS: Move NFS client's IP address parser to nfs_common/ Chuck Lever
2008-11-05 17:29   ` [PATCH 12/13] NFSD: Support IPv6 addresses in write_failover_ip() Chuck Lever
2008-11-05 17:29   ` [PATCH 13/13] NFSD: Enable NFS server use of AF_INET6 Chuck Lever
2008-11-05 20:06   ` [PATCH 01/12] lockd: fix inconsistent use of nsm_use_hostnames J. Bruce Fields
2008-11-05 20:06     ` [PATCH 02/12] lockd: kill redundant host->h_server check J. Bruce Fields
2008-11-05 20:06       ` [PATCH 03/12] lockd: fix nsm_unmonitor return value J. Bruce Fields
2008-11-05 20:06         ` [PATCH 04/12] lockd: unmonitor only when last host goes away J. Bruce Fields
2008-11-05 20:06           ` [PATCH 05/12] lockd: encapsulate nlm_hosts table variables in one structure J. Bruce Fields
2008-11-05 20:06             ` [PATCH 06/12] lockd: define host_for_each{_safe} macros J. Bruce Fields
2008-11-05 20:06               ` [PATCH 07/12] lockd: reorganize nlm_host_rebooted J. Bruce Fields
2008-11-05 20:06                 ` [PATCH 08/12] lockd: move debugging warning into a separate function J. Bruce Fields
2008-11-05 20:06                   ` [PATCH 09/12] lockd: move garbage collection loop into " J. Bruce Fields
2008-11-05 20:06                     ` [PATCH 10/12] lockd: move immediate host expiry " J. Bruce Fields
2008-11-05 20:06                       ` [PATCH 11/12] lockd: split client and server host lists J. Bruce Fields
2008-11-05 20:06                         ` [PATCH 12/12] lockd: remove redundant rpc_shutdown_client() J. Bruce Fields
2008-11-06 12:17                           ` Jeff Layton
     [not found]                           ` <20081106071733.6d4983ce@barsoom .rdu.redhat.com>
     [not found]                             ` <20081106071733.6d4983ce-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org>
2008-11-06 14:32                               ` Chuck Lever
2008-11-06 14:51                                 ` Jeff Layton
2008-11-06 22:10                               ` J. Bruce Fields
2008-11-06 22:21                                 ` Chuck Lever
2008-11-06 22:22                                   ` J. Bruce Fields [this message]
2008-11-06 22:25                                 ` Jeff Layton
2008-11-05 22:33                       ` [PATCH 10/12] lockd: move immediate host expiry into separate function Chuck Lever
2008-11-05 22:29                 ` [PATCH 07/12] lockd: reorganize nlm_host_rebooted Chuck Lever
2008-11-05 22:25             ` [PATCH 05/12] lockd: encapsulate nlm_hosts table variables in one structure Chuck Lever
2008-11-05 22:41               ` J. Bruce Fields
2008-11-05 23:11                 ` Trond Myklebust
     [not found]                   ` <1225926710.16857.94.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-11-05 23:21                     ` J. Bruce Fields
2008-11-05 22:22           ` [PATCH 04/12] lockd: unmonitor only when last host goes away Chuck Lever
2008-11-05 22:14         ` [PATCH 03/12] lockd: fix nsm_unmonitor return value Chuck Lever
2008-11-05 22:10     ` [PATCH 01/12] lockd: fix inconsistent use of nsm_use_hostnames Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081106222233.GH24916@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.