From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: __FILE__ (Re: [PATCH] framework for building modules externally)
Date: Fri, 7 Nov 2008 20:02:18 +0100 [thread overview]
Message-ID: <20081107190218.GA8625@thorin> (raw)
In-Reply-To: <49135D60.5080400@t-online.de>
On Thu, Nov 06, 2008 at 10:10:56PM +0100, Christian Franke wrote:
>
> See attached patch for a possible fix: Each module using grub_dprintf
> (here disk.c) may specify its name in 'this_file'. When all modules are
> changed, the '#define this_file' and all #undefs can be removed.
This adds redundancy which later makes it more work to move code around and
rename files, etc. Why not make it part of the build system? I.e. to build
foo.c, you need gcc -Dfile=foo.c foo.c ?
But then again, since gcc is free software perhaps it'd make more sense to
add new candy there? (e.g. __RELATIVE_FILE__ or so).
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-11-07 19:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 12:32 [PATCH] framework for building modules externally Robert Millan
2008-11-01 19:02 ` Robert Millan
2008-11-04 18:55 ` Vesa Jääskeläinen
2008-11-04 19:07 ` Robert Millan
2008-11-04 19:13 ` Vesa Jääskeläinen
2008-11-04 19:39 ` Robert Millan
2008-11-05 6:57 ` Christian Franke
2008-11-05 9:42 ` Robert Millan
2008-11-05 21:41 ` Christian Franke
2008-11-06 14:52 ` __FILE__ (Re: [PATCH] framework for building modules externally) Robert Millan
2008-11-06 21:10 ` Christian Franke
2008-11-07 19:02 ` Robert Millan [this message]
2008-11-10 20:39 ` Christian Franke
2008-11-06 14:54 ` [PATCH] framework for building modules externally Robert Millan
2008-11-06 20:43 ` Christian Franke
2008-11-07 19:05 ` Robert Millan
2008-11-08 11:33 ` Robert Millan
2008-11-10 20:44 ` Christian Franke
2009-04-10 23:19 ` phcoder
2009-04-13 13:55 ` Robert Millan
2008-11-05 9:51 ` Robert Millan
2008-11-08 11:29 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107190218.GA8625@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.