All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] KVM: Userspace: Make device-assignment work for kvm/ia64.
Date: Mon, 10 Nov 2008 05:59:01 +0000	[thread overview]
Message-ID: <200811101117.02029.amit.shah@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21983F921@pdsmsx503.ccr.corp.intel.com>

* On Friday 07 Nov 2008 15:55:18 Zhang, Xiantao wrote:

> --- a/qemu/vl.c
> +++ b/qemu/vl.c
> @@ -8694,7 +8694,7 @@ static void help(int exitcode)
>  #endif
>  	   "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n"
>  	   "-no-kvm-pit	    disable KVM kernel mode PIT\n"
> -#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(__linux__)
> +#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(TARGET_IA64)
> || defined(__linux__) "-pcidevice

It would be better to use #if defined (USE_KVM_DEVICE_ASSIGNMENT) here (and in 
the rest of the file) instead of adding architectures to this list as is done 
in the Makefile.

Amit

WARNING: multiple messages have this Message-ID (diff)
From: Amit Shah <amit.shah@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Avi Kivity <avi@redhat.com>,
	"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Userspace: Make device-assignment work for kvm/ia64.
Date: Mon, 10 Nov 2008 11:17:01 +0530	[thread overview]
Message-ID: <200811101117.02029.amit.shah@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21983F921@pdsmsx503.ccr.corp.intel.com>

* On Friday 07 Nov 2008 15:55:18 Zhang, Xiantao wrote:

> --- a/qemu/vl.c
> +++ b/qemu/vl.c
> @@ -8694,7 +8694,7 @@ static void help(int exitcode)
>  #endif
>  	   "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n"
>  	   "-no-kvm-pit	    disable KVM kernel mode PIT\n"
> -#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(__linux__)
> +#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(TARGET_IA64)
> || defined(__linux__) "-pcidevice

It would be better to use #if defined (USE_KVM_DEVICE_ASSIGNMENT) here (and in 
the rest of the file) instead of adding architectures to this list as is done 
in the Makefile.

Amit

  parent reply	other threads:[~2008-11-10  5:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 10:25 [PATCH] KVM: Userspace: Make device-assignment work for kvm/ia64 Zhang, Xiantao
2008-11-07 10:25 ` Zhang, Xiantao
2008-11-09 10:07 ` Avi Kivity
2008-11-09 10:07   ` Avi Kivity
2008-11-10  5:47 ` Amit Shah [this message]
2008-11-10  5:59   ` Amit Shah
2008-11-10  5:51 ` [PATCH] KVM: Userspace: Make device-assignment work for Zhang, Xiantao
2008-11-10  5:51   ` [PATCH] KVM: Userspace: Make device-assignment work for kvm/ia64 Zhang, Xiantao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811101117.02029.amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.