From: "Jörn Engel" <joern@logfs.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Tso <tytso@mit.edu>,
Peter Staubach <staubach@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]: ext4: fix big endian
Date: Mon, 10 Nov 2008 20:31:36 +0100 [thread overview]
Message-ID: <20081110193135.GA18378@logfs.org> (raw)
In-Reply-To: <1226340578.22742.4.camel@brick>
On Mon, 10 November 2008 10:09:38 -0800, Harvey Harrison wrote:
>
> I'd say that it's getting close to just being able to turn it on by
> default. A lot of the really verbose offenders have been annotated
> now, drivers/ieee1394, drivers/scsi, drivers/message and some of the
> older areas of drivers/net will get noisy, I was going to send an RFC
> for 2.6.29 and continue to chip away at the output.
My argument for the define is that it doesn't hurt much if endian checks
are enabled globally, but helps a lot if they are not. So until it is
clear that endian checks will be enabled, it may still be a good idea.
Jörn
--
It's not whether you win or lose, it's how you place the blame.
-- unknown
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Tso <tytso@mit.edu>,
Peter Staubach <staubach@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]: ext4: fix big endian
Date: Mon, 10 Nov 2008 20:31:36 +0100 [thread overview]
Message-ID: <20081110193135.GA18378@logfs.org> (raw)
In-Reply-To: <1226340578.22742.4.camel@brick>
On Mon, 10 November 2008 10:09:38 -0800, Harvey Harrison wrote:
>
> I'd say that it's getting close to just being able to turn it on by
> default. A lot of the really verbose offenders have been annotated
> now, drivers/ieee1394, drivers/scsi, drivers/message and some of the
> older areas of drivers/net will get noisy, I was going to send an RFC
> for 2.6.29 and continue to chip away at the output.
My argument for the define is that it doesn't hurt much if endian checks
are enabled globally, but helps a lot if they are not. So until it is
clear that endian checks will be enabled, it may still be a good idea.
Jörn
--
It's not whether you win or lose, it's how you place the blame.
-- unknown
next prev parent reply other threads:[~2008-11-10 19:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 15:00 EXT4-fs: not enough memory for 522250 flex groups Christian Borntraeger
2008-11-06 15:51 ` [PATCH]: ext4: fix big endian (was: not enough memory for 522250 flex groups) Christian Borntraeger
2008-11-06 16:06 ` [PATCH]: ext4: fix big endian Peter Staubach
2008-11-06 16:15 ` Christian Borntraeger
2008-11-06 16:32 ` Aneesh Kumar K.V
2008-11-06 16:38 ` Christoph Hellwig
2008-11-06 17:11 ` Christian Borntraeger
2008-11-06 17:33 ` Theodore Tso
2008-11-06 17:39 ` Christoph Hellwig
2008-11-06 17:39 ` Christoph Hellwig
2008-11-06 17:48 ` Alexey Dobriyan
2008-11-08 22:35 ` Jörn Engel
2008-11-08 22:35 ` Jörn Engel
2008-11-10 18:09 ` Harvey Harrison
2008-11-10 18:09 ` Harvey Harrison
2008-11-10 19:31 ` Jörn Engel [this message]
2008-11-10 19:31 ` Jörn Engel
2008-11-06 17:39 ` Christoph Hellwig
2008-11-06 16:06 ` [PATCH]: ext4: fix big endian (was: not enough memory for 522250 flex groups) Andreas Schwab
2008-11-06 16:06 ` Andreas Schwab
2008-11-06 16:59 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110193135.GA18378@logfs.org \
--to=joern@logfs.org \
--cc=borntraeger@de.ibm.com \
--cc=harvey.harrison@gmail.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=staubach@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.