* - fat-kill-d_invalidate-in-vfat_lookup.patch removed from -mm tree
@ 2008-11-10 20:33 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2008-11-10 20:33 UTC (permalink / raw)
To: hirofumi, mm-commits
The patch titled
fat: Kill d_invalidate() in vfat_lookup()
has been removed from the -mm tree. Its filename was
fat-kill-d_invalidate-in-vfat_lookup.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: fat: Kill d_invalidate() in vfat_lookup()
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
d_invalidate() for positive dentry doesn't work in some cases
(vfsmount, nfsd, and maybe others). shrink_dcache_parent() by
d_invalidate() is pointless for vfat usage at all.
So, this kills it, and intead of it uses d_move().
To save old behavior, this returns alias simply for directory (don't
change pwd, etc..). the directory lookup shouldn't be important for
performance.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/fat/namei_vfat.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff -puN fs/fat/namei_vfat.c~fat-kill-d_invalidate-in-vfat_lookup fs/fat/namei_vfat.c
--- a/fs/fat/namei_vfat.c~fat-kill-d_invalidate-in-vfat_lookup
+++ a/fs/fat/namei_vfat.c
@@ -745,13 +745,12 @@ static struct dentry *vfat_lookup(struct
*
* Switch to new one for reason of locality if possible.
*/
- if (d_invalidate(alias) == 0)
- dput(alias);
- else {
- iput(inode);
- unlock_super(sb);
- return alias;
- }
+ BUG_ON(d_unhashed(alias));
+ if (!S_ISDIR(inode->i_mode))
+ d_move(alias, dentry);
+ iput(inode);
+ unlock_super(sb);
+ return alias;
}
out:
unlock_super(sb);
_
Patches currently in -mm which might be from hirofumi@mail.parknet.co.jp are
linux-next.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-11-10 20:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-10 20:33 - fat-kill-d_invalidate-in-vfat_lookup.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.