All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Neyman <avn@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code
Date: Mon, 10 Nov 2008 22:49:02 -0800	[thread overview]
Message-ID: <200811102249.02725.avn@emcraft.com> (raw)
In-Reply-To: <491040B1.7080407@gmx.de>

Michael,

I tried to reproduce the bug you mentioned (multiple appearance of 
directories in ls output) using the script you provided, to no avail: 
ls correctly showed the top-level directory, both with and without 
CFG_JFFS2_SORT_FRAGMENTS option.

I am inclined to suspect the same cause as you mentioned below:

> Our u-boot is not placed in flash were it is located to on compilation
> time. static const char * points into flash space at some not properly
> initialized flash space.

This would affect all global and static variables, with unpredictable 
results. Could you try to reproduce this bug with u-boot placed at the 
address it was linked to?

As a side note, your fix for compilation with CFG_JFFS2_SORT_FRAGMENTS 
option turned on would be better as follows: replace

  if (pL->readbuf == NULL)
     put_fl_mem(jNode);

with

  put_fl_mem(jNode, pL->readbuf);

(put_fl_mem already performs this check)


Regards,
Alexey.

  parent reply	other threads:[~2008-11-11  6:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  5:53 [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: add sector_size field to part_info structure Ilya Yanok
2008-10-13  8:17   ` Wolfgang Denk
2008-10-15 12:35     ` Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: rewrite jffs2 scanning code based on Linux one Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: summary support Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: fix searching for latest version in jffs2_1pass_list_inodes() Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: add buffer to cache flash accesses Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: cache data_crc results Ilya Yanok
2008-10-14  9:25   ` Michael Lawnick
2008-10-13  8:14 ` [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code Wolfgang Denk
2008-10-15 12:44   ` Ilya Yanok
2008-10-16 12:36     ` Michael Lawnick
2008-11-01  1:00       ` Ilya Yanok
2008-11-02 16:02         ` Wolfgang Denk
2008-11-02 19:08           ` Ilya Yanok
2008-11-04 11:14         ` Michael Lawnick
2008-11-04 12:31           ` Michael Lawnick
2008-11-04 13:14             ` Joakim Tjernlund
2008-11-05  7:59               ` Michael Lawnick
2008-11-11  6:49             ` Alexey Neyman [this message]
2008-11-11  8:19               ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811102249.02725.avn@emcraft.com \
    --to=avn@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.