All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Lawnick <nospam_lawnick@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code
Date: Tue, 04 Nov 2008 13:31:45 +0100	[thread overview]
Message-ID: <491040B1.7080407@gmx.de> (raw)
In-Reply-To: <49102E92.7010909@gmx.de>

Michael Lawnick said the following:
...
> - output of access rights is still corrupted, e.g.:
>  d????-??-?        0 Tue Oct 21 11:08:17 2008 10
>  -????-??-?   262144 Thu Jan 01 00:00:33 1970 u-boot.bin
>  d????-??-?        0 Tue Oct 21 11:08:32 2008 1
>  d????-??-?        0 Tue Oct 21 11:00:58 2008 2
...

Ok, fixed this in my code:
in jffs2_1pass.c @@ mkmodestr(unsigned long mode, char *str)
you'll find declaration
    static const char *l = "xwr";

Although this is per se correct, it is not needed in context and screws
up 'ls' in my case: Our u-boot is not placed in flash were it is located
to on compilation time. static const char * points into flash space at
some not properly initialized flash space. After modifying to
    char *l = "xwr";
output of access rights is fine now:
 drwxr-xr-x        0 Tue Oct 21 11:08:17 2008 10
 -rwxr-xr-x   262144 Thu Jan 01 00:00:33 1970 u-boot.bin
 drwxr-xr-x        0 Tue Oct 21 11:08:32 2008 1
 drwxr-xr-x        0 Tue Oct 21 11:00:58 2008 2

(Still directories are listed multiple times)

Could we modify this declaration to my non-static version in the trunk?

-- 

Michael Lawnick
Software Design Engineer

Lise-Meitner-Str. 7/1
89081 Ulm
Tel: +49 731 9533 2066

Michael.Lawnick.ext at nsn.com
http://www.nokiasiemensnetworks.com/global/

Think before you print

  reply	other threads:[~2008-11-04 12:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  5:53 [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: add sector_size field to part_info structure Ilya Yanok
2008-10-13  8:17   ` Wolfgang Denk
2008-10-15 12:35     ` Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: rewrite jffs2 scanning code based on Linux one Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: summary support Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: fix searching for latest version in jffs2_1pass_list_inodes() Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: add buffer to cache flash accesses Ilya Yanok
2008-10-13  5:53 ` [U-Boot] [PATCH] jffs2: cache data_crc results Ilya Yanok
2008-10-14  9:25   ` Michael Lawnick
2008-10-13  8:14 ` [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code Wolfgang Denk
2008-10-15 12:44   ` Ilya Yanok
2008-10-16 12:36     ` Michael Lawnick
2008-11-01  1:00       ` Ilya Yanok
2008-11-02 16:02         ` Wolfgang Denk
2008-11-02 19:08           ` Ilya Yanok
2008-11-04 11:14         ` Michael Lawnick
2008-11-04 12:31           ` Michael Lawnick [this message]
2008-11-04 13:14             ` Joakim Tjernlund
2008-11-05  7:59               ` Michael Lawnick
2008-11-11  6:49             ` Alexey Neyman
2008-11-11  8:19               ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491040B1.7080407@gmx.de \
    --to=nospam_lawnick@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.