* [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage
@ 2008-11-12 12:52 Arnaldo Carvalho de Melo
2008-11-12 17:21 ` Mathieu Desnoyers
0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2008-11-12 12:52 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: Linux Kernel Mailing List
diff --git a/include/linux/marker.h b/include/linux/marker.h
index 889196c..6213b5e 100644
--- a/include/linux/marker.h
+++ b/include/linux/marker.h
@@ -12,6 +12,7 @@
* See the file COPYING for more details.
*/
+#include <stdarg.h>
#include <linux/types.h>
struct module;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage
2008-11-12 12:52 [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage Arnaldo Carvalho de Melo
@ 2008-11-12 17:21 ` Mathieu Desnoyers
2008-11-12 18:01 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Desnoyers @ 2008-11-12 17:21 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Linux Kernel Mailing List
* Arnaldo Carvalho de Melo (acme@redhat.com) wrote:
> diff --git a/include/linux/marker.h b/include/linux/marker.h
> index 889196c..6213b5e 100644
> --- a/include/linux/marker.h
> +++ b/include/linux/marker.h
> @@ -12,6 +12,7 @@
> * See the file COPYING for more details.
> */
>
> +#include <stdarg.h>
Hrm given it's already included in kernel.h for printk, I am not sure
it's required here ? Although it cannot hurt to add it explicitly.
Mathieu
> #include <linux/types.h>
>
> struct module;
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage
2008-11-12 17:21 ` Mathieu Desnoyers
@ 2008-11-12 18:01 ` Arnaldo Carvalho de Melo
2008-11-12 18:49 ` Mathieu Desnoyers
0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2008-11-12 18:01 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: Arnaldo Carvalho de Melo, Linux Kernel Mailing List
Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu:
> * Arnaldo Carvalho de Melo (acme@redhat.com) wrote:
> > diff --git a/include/linux/marker.h b/include/linux/marker.h
> > index 889196c..6213b5e 100644
> > --- a/include/linux/marker.h
> > +++ b/include/linux/marker.h
> > @@ -12,6 +12,7 @@
> > * See the file COPYING for more details.
> > */
> >
> > +#include <stdarg.h>
>
> Hrm given it's already included in kernel.h for printk, I am not sure
> it's required here ? Although it cannot hurt to add it explicitly.
Well, its just that while writing code I noticed that if I included
marker.h as the first include the compilation would fail.
My impression was that if you use something, you should include its
definition, not relying on the includes hell.
> Mathieu
>
> > #include <linux/types.h>
> >
> > struct module;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage
2008-11-12 18:01 ` Arnaldo Carvalho de Melo
@ 2008-11-12 18:49 ` Mathieu Desnoyers
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Desnoyers @ 2008-11-12 18:49 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Linux Kernel Mailing List
* Arnaldo Carvalho de Melo (acme@redhat.com) wrote:
> Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu:
> > * Arnaldo Carvalho de Melo (acme@redhat.com) wrote:
> > > diff --git a/include/linux/marker.h b/include/linux/marker.h
> > > index 889196c..6213b5e 100644
> > > --- a/include/linux/marker.h
> > > +++ b/include/linux/marker.h
> > > @@ -12,6 +12,7 @@
> > > * See the file COPYING for more details.
> > > */
> > >
> > > +#include <stdarg.h>
> >
> > Hrm given it's already included in kernel.h for printk, I am not sure
> > it's required here ? Although it cannot hurt to add it explicitly.
>
> Well, its just that while writing code I noticed that if I included
> marker.h as the first include the compilation would fail.
>
> My impression was that if you use something, you should include its
> definition, not relying on the includes hell.
>
Ok,
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Thanks,
Mathieu
> > Mathieu
> >
> > > #include <linux/types.h>
> > >
> > > struct module;
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-12 18:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-12 12:52 [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage Arnaldo Carvalho de Melo
2008-11-12 17:21 ` Mathieu Desnoyers
2008-11-12 18:01 ` Arnaldo Carvalho de Melo
2008-11-12 18:49 ` Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.