All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch	instead of common
Date: Wed, 12 Nov 2008 20:45:51 +0100	[thread overview]
Message-ID: <20081112194551.GA9862@game.jcrosoft.org> (raw)
In-Reply-To: <1aad82fa0811121136t3e33762co5567d173e3172c2c@mail.gmail.com>

On 14:36 Wed 12 Nov     , Mike Frysinger wrote:
> On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and
> > soc to print more information
> 
> there seems to be things that all arches print ... like memory and
> flash information.  perhaps that should be left in the common
> bdinfo().

I've prefered to let arch print this how they wish

> > +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> > +       if(soc_bdinfo)
> > +       if(board_bdinfo)
> 
> you've got random whitespace damage all over this patch ...

I known, but I not suposed to fix PPC whitespace in the patch
I've an other one when everyone will agree on this one

Best Regards,
J.

  reply	other threads:[~2008-11-12 19:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 20:54 [U-Boot] [PATCH] cmd_bdinfo: move implementation to arch instead of common Jean-Christophe PLAGNIOL-VILLARD
2008-11-12 14:02 ` Jerry Van Baren
2008-11-12 14:57   ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-12 19:13     ` [U-Boot] [PATCH V2] " Jean-Christophe PLAGNIOL-VILLARD
2008-11-12 19:36       ` Mike Frysinger
2008-11-12 19:45         ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-11-12 19:55           ` Mike Frysinger
2008-11-12 20:06             ` Jean-Christophe PLAGNIOL-VILLARD
2008-12-04 12:29       ` [U-Boot] [PATCH V3] " Jean-Christophe PLAGNIOL-VILLARD
2008-12-04 12:35         ` [U-Boot] [PATCH V4] " Jean-Christophe PLAGNIOL-VILLARD
2008-12-04 13:36           ` Joakim Tjernlund
2008-11-13  8:15     ` [U-Boot] [PATCH] " Haavard Skinnemoen
2008-11-12 16:17   ` Mike Frysinger
2008-11-12 16:31     ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-12 17:55       ` Mike Frysinger
2008-11-12 18:08         ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-12 18:16           ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112194551.GA9862@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.