Re: [PATCH 3/4] HSMMC: Add support for the second controller

[Tony Lindgren <tony@atomide.com>]

* Grazvydas Ignotas <notasas@gmail.com> [081110 02:37]:
> > +static int hsmmc2_set_power(struct device *dev, int slot, int power_on, int vdd)
> > +{
> > +	int ret;
> > +
> > +	struct hsmmc_controller *c = &hsmmc[1];
> > +
> > +	if (power_on) {
> > +		u32 reg;
> > +
> > +		reg = omap_ctrl_readl(c->control_devconf_offset);
> > +		reg |= OMAP2_MMCSDIO2ADPCLKISEL;
> > +		omap_ctrl_writel(reg, c->control_devconf_offset);
> 
> This is not correct for pandora, it needs input clock from the
> transceiver, not loop back clock. Perhaps this can be controlled by
> platform data, or removed altogether and left for the bootloader?

Let's just pass that with the twl4030_hsmmc_info. Having the
bootloader initialize things adds unnecessary dependencies between
the kernel and bootloader version. Can you send a patch please?

Regards,

Tony