All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/6] tx493x: fix intendation
@ 2008-11-12 21:14 Bartlomiej Zolnierkiewicz
  2008-11-12 22:48 ` Sergei Shtylyov
  2008-11-13 12:52 ` Atsushi Nemoto
  0 siblings, 2 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-11-12 21:14 UTC (permalink / raw)
  To: linux-ide; +Cc: linux-kernel, Atsushi Nemoto, Sergei Shtylyov

Trivial CodingStyle fixup for tx4938ide and tx4939ide drivers.

CC: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/tx4938ide.c |   10 +++++-----
 drivers/ide/tx4939ide.c |   42 +++++++++++++++++++++---------------------
 2 files changed, 26 insertions(+), 26 deletions(-)

Index: b/drivers/ide/tx4938ide.c
===================================================================
--- a/drivers/ide/tx4938ide.c
+++ b/drivers/ide/tx4938ide.c
@@ -216,16 +216,16 @@ static const struct ide_tp_ops tx4938ide
 #endif	/* __BIG_ENDIAN */
 
 static const struct ide_port_ops tx4938ide_port_ops = {
-	.set_pio_mode = tx4938ide_set_pio_mode,
+	.set_pio_mode		= tx4938ide_set_pio_mode,
 };
 
 static const struct ide_port_info tx4938ide_port_info __initdata = {
-	.port_ops = &tx4938ide_port_ops,
+	.port_ops		= &tx4938ide_port_ops,
 #ifdef __BIG_ENDIAN
-	.tp_ops = &tx4938ide_tp_ops,
+	.tp_ops			= &tx4938ide_tp_ops,
 #endif
-	.host_flags = IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA,
-	.pio_mask = ATA_PIO5,
+	.host_flags		= IDE_HFLAG_MMIO | IDE_HFLAG_NO_DMA,
+	.pio_mask		= ATA_PIO5,
 };
 
 static int __init tx4938ide_probe(struct platform_device *pdev)
Index: b/drivers/ide/tx4939ide.c
===================================================================
--- a/drivers/ide/tx4939ide.c
+++ b/drivers/ide/tx4939ide.c
@@ -617,33 +617,33 @@ static const struct ide_tp_ops tx4939ide
 #endif	/* __LITTLE_ENDIAN */
 
 static const struct ide_port_ops tx4939ide_port_ops = {
-	.set_pio_mode = tx4939ide_set_pio_mode,
-	.set_dma_mode = tx4939ide_set_dma_mode,
-	.clear_irq = tx4939ide_clear_irq,
-	.cable_detect = tx4939ide_cable_detect,
+	.set_pio_mode		= tx4939ide_set_pio_mode,
+	.set_dma_mode		= tx4939ide_set_dma_mode,
+	.clear_irq		= tx4939ide_clear_irq,
+	.cable_detect		= tx4939ide_cable_detect,
 };
 
 static const struct ide_dma_ops tx4939ide_dma_ops = {
-	.dma_host_set = tx4939ide_dma_host_set,
-	.dma_setup = tx4939ide_dma_setup,
-	.dma_exec_cmd = ide_dma_exec_cmd,
-	.dma_start = ide_dma_start,
-	.dma_end = tx4939ide_dma_end,
-	.dma_test_irq = tx4939ide_dma_test_irq,
-	.dma_lost_irq = ide_dma_lost_irq,
-	.dma_timeout = ide_dma_timeout,
+	.dma_host_set		= tx4939ide_dma_host_set,
+	.dma_setup		= tx4939ide_dma_setup,
+	.dma_exec_cmd		= ide_dma_exec_cmd,
+	.dma_start		= ide_dma_start,
+	.dma_end		= tx4939ide_dma_end,
+	.dma_test_irq		= tx4939ide_dma_test_irq,
+	.dma_lost_irq		= ide_dma_lost_irq,
+	.dma_timeout		= ide_dma_timeout,
 };
 
 static const struct ide_port_info tx4939ide_port_info __initdata = {
-	.init_hwif = tx4939ide_init_hwif,
-	.init_dma = tx4939ide_init_dma,
-	.port_ops = &tx4939ide_port_ops,
-	.dma_ops = &tx4939ide_dma_ops,
-	.tp_ops = &tx4939ide_tp_ops,
-	.host_flags = IDE_HFLAG_MMIO,
-	.pio_mask = ATA_PIO4,
-	.mwdma_mask = ATA_MWDMA2,
-	.udma_mask = ATA_UDMA5,
+	.init_hwif		= tx4939ide_init_hwif,
+	.init_dma		= tx4939ide_init_dma,
+	.port_ops		= &tx4939ide_port_ops,
+	.dma_ops		= &tx4939ide_dma_ops,
+	.tp_ops			= &tx4939ide_tp_ops,
+	.host_flags		= IDE_HFLAG_MMIO,
+	.pio_mask		= ATA_PIO4,
+	.mwdma_mask		= ATA_MWDMA2,
+	.udma_mask		= ATA_UDMA5,
 };
 
 static int __init tx4939ide_probe(struct platform_device *pdev)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/6] tx493x: fix intendation
  2008-11-12 21:14 [PATCH 1/6] tx493x: fix intendation Bartlomiej Zolnierkiewicz
@ 2008-11-12 22:48 ` Sergei Shtylyov
  2008-11-13 12:52 ` Atsushi Nemoto
  1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2008-11-12 22:48 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel, Atsushi Nemoto

Hello.

Bartlomiej Zolnierkiewicz wrote:

> Trivial CodingStyle fixup for tx4938ide and tx4939ide drivers.
>   

   I didn't know CodingStyle covers the field initializers. Anyway, I'm 
sure you meant "indentation". :-P

> CC: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>   

Acked-by: Sergei Shtyltov <sshtylyov@ru.mvista.com>

MBR, Sergei



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/6] tx493x: fix intendation
  2008-11-12 21:14 [PATCH 1/6] tx493x: fix intendation Bartlomiej Zolnierkiewicz
  2008-11-12 22:48 ` Sergei Shtylyov
@ 2008-11-13 12:52 ` Atsushi Nemoto
  1 sibling, 0 replies; 3+ messages in thread
From: Atsushi Nemoto @ 2008-11-13 12:52 UTC (permalink / raw)
  To: bzolnier; +Cc: linux-ide, linux-kernel, sshtylyov

On Wed, 12 Nov 2008 22:14:12 +0100, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> Trivial CodingStyle fixup for tx4938ide and tx4939ide drivers.

Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-13 12:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-12 21:14 [PATCH 1/6] tx493x: fix intendation Bartlomiej Zolnierkiewicz
2008-11-12 22:48 ` Sergei Shtylyov
2008-11-13 12:52 ` Atsushi Nemoto

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.