From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] acpiphp: Identify more removable slots
Date: Thu, 13 Nov 2008 20:51:52 +0000 [thread overview]
Message-ID: <20081113205152.GA11577@srcf.ucam.org> (raw)
In-Reply-To: <20081113204859.GC1617@parisc-linux.org>
On Thu, Nov 13, 2008 at 01:48:59PM -0700, Matthew Wilcox wrote:
> Why not:
>
> status = acpi_get_handle(handle, "_EJ0", &tmp);
> if (ACPI_SUCCESS(status))
> return 1;
>
> status = acpi_get_handle(handle, "_RMV", &tmp);
> if (ACPI_SUCCESS(status))
> return 1;
>
> return 0;
Oh, yes, that'd work.
> > + if (ACPI_SUCCESS(status) || is_dock_device(handle))
> > + valid = 1;
> > +
> > + if (!valid)
> > return AE_OK;
>
> This looks like almost the same code as above. New helper function?
It's not quite the same, but yes, I'll see if it can be reduced.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2008-11-13 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 20:27 [PATCH 1/2] acpiphp: Identify more removable slots Matthew Garrett
2008-11-13 20:29 ` [PATCH 2/2] acpiphp: Call _LCK method Matthew Garrett
2008-11-13 20:48 ` [PATCH 1/2] acpiphp: Identify more removable slots Matthew Wilcox
2008-11-13 20:51 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113205152.GA11577@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.