From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: David Brownell <david-b@pacbell.net>,
linux-omap@vger.kernel.org, Felipe Balbi <felipe.balbi@nokia.com>,
Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] omap1: clk: make clk fwk build again on omap1
Date: Thu, 13 Nov 2008 13:05:05 -0800 [thread overview]
Message-ID: <20081113210503.GC3106@atomide.com> (raw)
In-Reply-To: <20081113204749.GC25855@frodo>
* Felipe Balbi <me@felipebalbi.com> [081113 12:48]:
> On Thu, Nov 13, 2008 at 11:23:12AM -0800, David Brownell wrote:
> > On Thursday 13 November 2008, Tony Lindgren wrote:
> > > Huh? At least OSK builds and boots just fine here.
> > > Have you tested this patch?
> >
> > But I got a boatload of build warnings for clocks,
> > even though they were just warnings.
Yeah I get warnings to with l-o tree, but not in with mainline tree.
> > It did boot, but root-on-CF seems to have some
> > oopsing problems. I think I saw some IDE/block
> > layer updates post-RC3, maybe they'll fix that.
>
> The warnings is because enabled_reg (from struct clk on omap) changed
> from a pointer (probably void __iomem *, gotta check history) to a u32
> and only omap2/3 was fixed. This patch fixes that in fact. But for me,
> funny enough, i didn't get warnings, I got build error :-s
Weird. Anyways, since it's OK in the mainline tree, let's wait until
Paul and Russell have sorted out the clock fwk issues.
Tony
next prev parent reply other threads:[~2008-11-13 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 22:56 [PATCH] omap1: clk: make clk fwk build again on omap1 Felipe Balbi
2008-11-13 18:55 ` Tony Lindgren
2008-11-13 18:57 ` Felipe Balbi
2008-11-13 19:02 ` Tony Lindgren
2008-11-13 19:12 ` Felipe Balbi
2008-11-13 19:23 ` David Brownell
2008-11-13 20:47 ` Felipe Balbi
2008-11-13 21:05 ` Tony Lindgren [this message]
2008-11-13 21:15 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113210503.GC3106@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.