From: Felipe Balbi <me@felipebalbi.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <me@felipebalbi.com>,
linux-omap@vger.kernel.org, Felipe Balbi <felipe.balbi@nokia.com>,
Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] omap1: clk: make clk fwk build again on omap1
Date: Thu, 13 Nov 2008 21:12:35 +0200 [thread overview]
Message-ID: <20081113191234.GB25855@frodo> (raw)
In-Reply-To: <20081113190241.GB3106@atomide.com>
On Thu, Nov 13, 2008 at 11:02:42AM -0800, Tony Lindgren wrote:
> * Felipe Balbi <me@felipebalbi.com> [081113 11:00]:
> > On Thu, Nov 13, 2008 at 10:55:49AM -0800, Tony Lindgren wrote:
> > > * Felipe Balbi <me@felipebalbi.com> [081111 14:57]:
> > > > From: Felipe Balbi <felipe.balbi@nokia.com>
> > > >
> > > > Fix it by passing u32 into enable_reg and letting
> > > > clock.c use OMAP1_IO_ADDRESS().
> > > >
> > > > This will probably be changed by a better solution
> > > > later on, but at least we make it buildable again.
> > >
> > > Huh? At least OSK builds and boots just fine here.
> > > Have you tested this patch?
> >
> > It builds with or without this patch ?
>
> Builds and boots without this patch.
Funny, I got broken compilation on all omap1 defconfigs, that's why I
put down this patch. My toolchain could be broken, maybe ? Gotta check
that.
--
balbi
next prev parent reply other threads:[~2008-11-13 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 22:56 [PATCH] omap1: clk: make clk fwk build again on omap1 Felipe Balbi
2008-11-13 18:55 ` Tony Lindgren
2008-11-13 18:57 ` Felipe Balbi
2008-11-13 19:02 ` Tony Lindgren
2008-11-13 19:12 ` Felipe Balbi [this message]
2008-11-13 19:23 ` David Brownell
2008-11-13 20:47 ` Felipe Balbi
2008-11-13 21:05 ` Tony Lindgren
2008-11-13 21:15 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113191234.GB25855@frodo \
--to=me@felipebalbi.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.