All of lore.kernel.org
 help / color / mirror / Atom feed
* - i5000-edac-hold-reference-to-mci-kobject.patch removed from -mm tree
@ 2008-11-13 21:26 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2008-11-13 21:26 UTC (permalink / raw)
  To: djwong, norsk5, mm-commits


The patch titled
     i5000-edac: hold reference to mci kobject
has been removed from the -mm tree.  Its filename was
     i5000-edac-hold-reference-to-mci-kobject.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: i5000-edac: hold reference to mci kobject
From: "Darrick J. Wong" <djwong@us.ibm.com>

It turns out that edac_mc_del_mc will kobject_put the last kref on the mci
object.  If the timing is just right, that means that the mci object is
freed before before i5000_remove_one has a chance to free the resources
associated with it, causing a null pointer exceptions when unloading the
driver.  Insert a kobject_{get,put} pair so that this doesn't happen.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Cc: Doug Thompson <norsk5@yahoo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/edac/i5000_edac.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff -puN drivers/edac/i5000_edac.c~i5000-edac-hold-reference-to-mci-kobject drivers/edac/i5000_edac.c
--- a/drivers/edac/i5000_edac.c~i5000-edac-hold-reference-to-mci-kobject
+++ a/drivers/edac/i5000_edac.c
@@ -1381,6 +1381,7 @@ static int i5000_probe1(struct pci_dev *
 	if (mci == NULL)
 		return -ENOMEM;
 
+	kobject_get(&mci->edac_mci_kobj);
 	debugf0("MC: " __FILE__ ": %s(): mci = %p\n", __func__, mci);
 
 	mci->dev = &pdev->dev;	/* record ptr  to the generic device */
@@ -1453,6 +1454,7 @@ fail1:
 	i5000_put_devices(mci);
 
 fail0:
+	kobject_put(&mci->edac_mci_kobj);
 	edac_mc_free(mci);
 	return -ENODEV;
 }
@@ -1498,7 +1500,7 @@ static void __devexit i5000_remove_one(s
 
 	/* retrieve references to resources, and free those resources */
 	i5000_put_devices(mci);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-11-13 21:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-13 21:26 - i5000-edac-hold-reference-to-mci-kobject.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.