Re: [patch/rft 2.6.28-rc3-omap] twl4030-core simplification

[Felipe Balbi <me@felipebalbi.com>]

On Thu, Nov 13, 2008 at 04:15:09PM -0800, David Brownell wrote:
> On Thursday 13 November 2008, Tony Lindgren wrote:
> > * David Brownell <david-b@pacbell.net> [081107 16:45]:
> > > From: David Brownell <dbrownell@users.sourceforge.net>
> > > 
> > > Minor cleanup to twl4030-core: define a helper function to populate
> > > a single child node, and use it to replace six inconsistent versions
> > > of the same logic.  Both object and source code shrink.
> > > 
> > > As part of this, some devices now have more IRQ resources:  battery
> > > charger, keypad, ADC, and USB transceiver.  That will help to remove
> > > some irq #defines that prevent this code from compiling on non-OMAP
> > > platforms.
> > 
> > Pushing to linux-omap tree while waiting for this to fall down from
> > mainline tree via Samuel's queue.
> 
> Hmm, better to revert this and send the updated version I sent
> as part of the regulator series... that returns the platform
> device, which is useful in setting up consumers of the regulator
> devices.
> 
> I hadn't gotten any test results other than knowing Felipe was
> using this.  So I'll hold off a bit on sending the updated
> patch to Samuel, probably till end-of-week, on the grounds that
> the keypad, battery, and ADC devices didn't get tested yet.

The new add_child() works quite ok and simplifies a lot the code. But
the regulator driver, I think we can hold a bit as that needs careful
testing.

-- 
balbi