From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: Felipe Balbi <me@felipebalbi.com>,
linux-omap@vger.kernel.org, Samuel Ortiz <sameo@openedhand.com>
Subject: Re: [patch/rft 2.6.28-rc3-omap] twl4030-core simplification
Date: Thu, 13 Nov 2008 17:30:23 -0800 [thread overview]
Message-ID: <20081114013017.GF3106@atomide.com> (raw)
In-Reply-To: <200811131705.47110.david-b@pacbell.net>
* David Brownell <david-b@pacbell.net> [081113 17:05]:
> On Thursday 13 November 2008, Tony Lindgren wrote:
> > If CONFIG_REGULATOR is not set, I get:
> >
> > drivers/mfd/twl4030-core.c: In function 'add_children':
> > drivers/mfd/twl4030-core.c:592: error: 'REGULATOR_MODE_OFF' undeclared (first use in this function)
> >
> > Where do you want to have that for now? Add it also into
> > twl4030-core.c like in twl4030-regulator.c?
>
> #ifndef REGULATOR_MODE_OFF
> #define REGULATOR_MODE_OFF 0
> #endif
>
> for now... but the fact that you're getting that at all seems to
> mean you're applying the third regulator patch (register regulators)
> without the fourth (debug oriented) which has that #ifndef.
>
> Don't merge regulator patches #3 or #4 yet ... #2 should be OK,
> but it's a NOP without #3 (which has the is ifdef issue).
OK, thanks. Pushed the first two only.
Tony
next prev parent reply other threads:[~2008-11-14 1:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 0:45 [patch/rft 2.6.28-rc3-omap] twl4030-core simplification David Brownell
2008-11-13 22:26 ` Tony Lindgren
2008-11-14 0:15 ` David Brownell
2008-11-14 0:35 ` Felipe Balbi
2008-11-14 0:42 ` Tony Lindgren
2008-11-14 0:52 ` Felipe Balbi
2008-11-14 1:00 ` Tony Lindgren
2008-11-14 1:05 ` David Brownell
2008-11-14 1:30 ` Tony Lindgren [this message]
2008-11-14 1:00 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114013017.GF3106@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.