From: Mike Frysinger <vapier@gentoo.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: unify mtd partition/device registration
Date: Sun, 16 Nov 2008 12:55:17 -0500 [thread overview]
Message-ID: <200811161255.18513.vapier@gentoo.org> (raw)
In-Reply-To: <20081116173453.GA703@logfs.org>
On Sunday 16 November 2008 12:34:54 Jörn Engel wrote:
> On Wed, 12 November 2008 18:38:53 -0500, Mike Frysinger wrote:
> > Rather than having every map/mtd driver doing the same sequence of
> > registering partitions and/or devices, implement common parse_mtd().
>
> I just added partitioning support to block2mtd. Looks like I might
> rethink the patch. :)
>
> > @@ -292,6 +292,43 @@ void put_mtd_device(struct mtd_info *mtd)
> > module_put(mtd->owner);
> > }
> >
> > +#include <linux/mtd/partitions.h>
>
> #include in the middle of the code?
maybe i'll stick a comment above it ... the reason was to be proactive in
preventing mtd partitioning code bleeding into the core. maybe i'm just
paranoid.
-mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Frysinger <vapier@gentoo.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: unify mtd partition/device registration
Date: Sun, 16 Nov 2008 12:55:17 -0500 [thread overview]
Message-ID: <200811161255.18513.vapier@gentoo.org> (raw)
In-Reply-To: <20081116173453.GA703@logfs.org>
On Sunday 16 November 2008 12:34:54 Jörn Engel wrote:
> On Wed, 12 November 2008 18:38:53 -0500, Mike Frysinger wrote:
> > Rather than having every map/mtd driver doing the same sequence of
> > registering partitions and/or devices, implement common parse_mtd().
>
> I just added partitioning support to block2mtd. Looks like I might
> rethink the patch. :)
>
> > @@ -292,6 +292,43 @@ void put_mtd_device(struct mtd_info *mtd)
> > module_put(mtd->owner);
> > }
> >
> > +#include <linux/mtd/partitions.h>
>
> #include in the middle of the code?
maybe i'll stick a comment above it ... the reason was to be proactive in
preventing mtd partitioning code bleeding into the core. maybe i'm just
paranoid.
-mike
next prev parent reply other threads:[~2008-11-16 17:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 23:38 [PATCH] mtd: unify mtd partition/device registration Mike Frysinger
2008-11-12 23:39 ` [PATCH] mtd/physmap: use parse_mtd() Mike Frysinger
2008-11-13 13:51 ` Atsushi Nemoto
2008-11-13 13:51 ` Atsushi Nemoto
2008-11-13 14:44 ` Mike Frysinger
2008-11-13 14:44 ` Mike Frysinger
2008-11-14 21:41 ` Andrew Morton
2008-11-14 21:41 ` Andrew Morton
2008-11-14 22:07 ` Mike Frysinger
2008-11-14 22:07 ` Mike Frysinger
2008-11-12 23:39 ` [PATCH] mtd/bfin-async-flash: " Mike Frysinger
2008-11-13 13:43 ` [PATCH] mtd: unify mtd partition/device registration Atsushi Nemoto
2008-11-13 13:43 ` Atsushi Nemoto
2008-11-13 14:28 ` Atsushi Nemoto
2008-11-13 14:28 ` Atsushi Nemoto
2008-11-13 14:51 ` Mike Frysinger
2008-11-13 14:51 ` Mike Frysinger
2008-11-13 15:51 ` Atsushi Nemoto
2008-11-13 15:51 ` Atsushi Nemoto
2008-11-13 15:55 ` Mike Frysinger
2008-11-13 15:55 ` Mike Frysinger
2008-11-13 14:47 ` Mike Frysinger
2008-11-13 14:47 ` Mike Frysinger
2008-11-14 21:39 ` Andrew Morton
2008-11-14 21:39 ` Andrew Morton
2008-11-16 17:34 ` Jörn Engel
2008-11-16 17:34 ` Jörn Engel
2008-11-16 17:55 ` Mike Frysinger [this message]
2008-11-16 17:55 ` Mike Frysinger
2008-11-16 18:02 ` Jörn Engel
2008-11-16 18:02 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811161255.18513.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=dwmw2@infradead.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.