* Re: [PATCH] scsi-ioctl: use clock_t <> jiffies
[not found] <31226729703643c98694.1714636915.miltonm@bga.com>
@ 2008-11-17 12:08 ` Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2008-11-17 12:08 UTC (permalink / raw)
To: Milton Miller; +Cc: linux-kernel
On Sat, Nov 15 2008, Milton Miller wrote:
> Convert the timeout ioctl scalling to use the clock_t functions
> which are much more accurate with some USER_HZ vs HZ combinations.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> ---
> While doing some work with low HZ rates for a simulator,
> I saw a divide-by-zero warning that pointed out these
> hz scales.
>
>
> Index: sim/block/scsi_ioctl.c
> ===================================================================
> --- sim.orig/block/scsi_ioctl.c 2008-11-11 01:19:29.000000000 -0600
> +++ sim/block/scsi_ioctl.c 2008-11-11 01:22:11.000000000 -0600
> @@ -60,7 +60,7 @@ static int scsi_get_bus(struct request_q
>
> static int sg_get_timeout(struct request_queue *q)
> {
> - return q->sg_timeout / (HZ / USER_HZ);
> + return jiffies_to_clock_t(q->sg_timeout);
> }
>
> static int sg_set_timeout(struct request_queue *q, int __user *p)
> @@ -68,7 +68,7 @@ static int sg_set_timeout(struct request
> int timeout, err = get_user(timeout, p);
>
> if (!err)
> - q->sg_timeout = timeout * (HZ / USER_HZ);
> + q->sg_timeout = clock_t_to_jiffies(timeout);
>
> return err;
> }
Thanks, applied to for-2.6.29
--
Jens Axboe
^ permalink raw reply [flat|nested] only message in thread