From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] fit: Fix little endian target support
Date: Tue, 18 Nov 2008 10:33:33 +0100 [thread overview]
Message-ID: <20081118093333.GK20874@game.jcrosoft.org> (raw)
In-Reply-To: <20081118085848.6810F832E89D@gemini.denx.de>
On 09:58 Tue 18 Nov , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <1226968111-965-2-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > bswap_32 and bswap_64 is for host on target we use
> > cpu_to_be32 and cpu_to_be64
>
> Hm.... do you consider this a style cleanup, or is there any real
> problem that needs fixing?
on little endian it does not compile
>
> > #if __BYTE_ORDER == __LITTLE_ENDIAN
> > +#ifdef USE_HOSTCC
> > #define fdt32_to_cpu(x) bswap_32(x)
> > #define cpu_to_fdt32(x) bswap_32(x)
> > #define fdt64_to_cpu(x) bswap_64(x)
> > #define cpu_to_fdt64(x) bswap_64(x)
> > #else
> > +#define fdt32_to_cpu(x) cpu_to_be32(x)
> > +#define cpu_to_fdt32(x) cpu_to_be32(x)
> > +#define fdt64_to_cpu(x) cpu_to_be64(x)
> > +#define cpu_to_fdt64(x) cpu_to_be64(x)
> > +#endif /* USE_HOSTCC */
>
> This is IMO wrong. If we implement such a change, then fdt32_to_cpu
> should translate to be32_to_cpu, and fdt64_to_cpu should translate to
> be64_to_cpu.
>
> But actually I do not see the need for this change.
I've try some arm little endian platfrom without it it does not compile at all
Best Regards,
J.
next prev parent reply other threads:[~2008-11-18 9:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 0:27 [U-Boot] Fix uImage.FIT support for little endian target and non PPC, M68K and SPARC target Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 0:28 ` [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 0:28 ` [U-Boot] [PATCH 2/2] fit: Fix little endian target support Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 8:58 ` Wolfgang Denk
2008-11-18 9:33 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-11-18 9:52 ` Wolfgang Denk
2008-11-18 10:19 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 8:55 ` [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage Wolfgang Denk
2008-11-18 9:30 ` [U-Boot] Address Space in Uboot MPC85xx Vignesh Kumar B
2008-11-18 12:14 ` Vignesh Kumar B
2008-11-18 13:28 ` Kumar Gala
2008-11-18 9:34 ` [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage Jean-Christophe PLAGNIOL-VILLARD
2008-11-18 9:55 ` Wolfgang Denk
2008-11-18 13:09 ` Kumar Gala
2008-11-18 13:16 ` Wolfgang Denk
2008-11-19 0:09 ` [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 0:18 ` [U-Boot] [PATCH] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and CONFIG_FIT independant Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 11:47 ` Wolfgang Denk
2008-11-20 21:59 ` [U-Boot] [PATCH V2] " Jean-Christophe PLAGNIOL-VILLARD
2008-11-20 22:30 ` Wolfgang Denk
2008-11-19 11:44 ` [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not Wolfgang Denk
2008-11-19 12:10 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 13:10 ` Wolfgang Denk
2008-11-19 13:22 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 14:22 ` Wolfgang Denk
2008-11-19 15:27 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118093333.GK20874@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.