All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand	usage
Date: Tue, 18 Nov 2008 10:34:37 +0100	[thread overview]
Message-ID: <20081118093437.GL20874@game.jcrosoft.org> (raw)
In-Reply-To: <20081118085547.736A1832E89D@gemini.denx.de>

On 09:55 Tue 18 Nov     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1226968111-965-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > boot_relocate_fdt can only be used on PPC, M68K and SPARC
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  common/cmd_bootm.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> > index a8f85e9..22e8b30 100644
> > --- a/common/cmd_bootm.c
> > +++ b/common/cmd_bootm.c
> > @@ -499,6 +499,7 @@ int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> >  			break;
> >  #endif
> >  #ifdef CONFIG_OF_LIBFDT
> > +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
> 
> This change seems wrong to me. There are PPC systems which do not use
> the device tree - why should we enable this code for these?
thats already the case by the ifdef CONFIG_OF_LIBFDT

Best Regards,
J.

  parent reply	other threads:[~2008-11-18  9:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18  0:27 [U-Boot] Fix uImage.FIT support for little endian target and non PPC, M68K and SPARC target Jean-Christophe PLAGNIOL-VILLARD
2008-11-18  0:28 ` [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage Jean-Christophe PLAGNIOL-VILLARD
2008-11-18  0:28   ` [U-Boot] [PATCH 2/2] fit: Fix little endian target support Jean-Christophe PLAGNIOL-VILLARD
2008-11-18  8:58     ` Wolfgang Denk
2008-11-18  9:33       ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-18  9:52         ` Wolfgang Denk
2008-11-18 10:19           ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-18  8:55   ` [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage Wolfgang Denk
2008-11-18  9:30     ` [U-Boot] Address Space in Uboot MPC85xx Vignesh Kumar B
2008-11-18 12:14       ` Vignesh Kumar B
2008-11-18 13:28         ` Kumar Gala
2008-11-18  9:34     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-11-18  9:55       ` [U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage Wolfgang Denk
2008-11-18 13:09         ` Kumar Gala
2008-11-18 13:16           ` Wolfgang Denk
2008-11-19  0:09   ` [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not Jean-Christophe PLAGNIOL-VILLARD
2008-11-19  0:18     ` [U-Boot] [PATCH] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and CONFIG_FIT independant Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 11:47       ` Wolfgang Denk
2008-11-20 21:59         ` [U-Boot] [PATCH V2] " Jean-Christophe PLAGNIOL-VILLARD
2008-11-20 22:30           ` Wolfgang Denk
2008-11-19 11:44     ` [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not Wolfgang Denk
2008-11-19 12:10       ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 13:10         ` Wolfgang Denk
2008-11-19 13:22           ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-19 14:22             ` Wolfgang Denk
2008-11-19 15:27               ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081118093437.GL20874@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.